Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to feed-io version 6 #213

Open
ardentsword opened this issue Aug 31, 2022 · 1 comment
Open

Update to feed-io version 6 #213

ardentsword opened this issue Aug 31, 2022 · 1 comment

Comments

@ardentsword
Copy link
Contributor

I assume there are plans to update this package to version 6 of feed-io as well?

If you could use help with this I can take a look as well, if so, could you give some pointers as what to look out for?

@ardentsword
Copy link
Contributor Author

ardentsword commented Sep 2, 2022

I have experimented with this a bit today, simply updating feed-io and modifying the services.yml to works perfectly:

    http.client:
        class: Symfony\Component\HttpClient\HttplugClient

    feedio.client:
        class: FeedIo\Adapter\Http\Client
        arguments: ['@http.client']

(And of course installing the symfony http client in this case with the psr-7 adapter, nyholm/psr7)
But my knowledge of symfony bundles is too limited here.

What would be a nice way to make this configurable?
-Manually injecting a service in the project service.yml seems very convoluted
-I though maybe about a sort of 'config factory', that injects to correct client adapter based on a configurable string?
-I also noticed php-http has a discovery plugin for this: https://docs.php-http.org/en/latest/discovery.html, perhaps that would be a nice default injection?
-I'm overthinking this massively?

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant