Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back unapply and copy, but marked as private #5

Open
alexarchambault opened this issue Oct 3, 2019 · 1 comment
Open

Add back unapply and copy, but marked as private #5

alexarchambault opened this issue Oct 3, 2019 · 1 comment

Comments

@alexarchambault
Copy link
Owner

It would be safe to still generate the unapply and copy methods, but with a private modifier. They could be used / helpful from the class body, but wouldn't belong to the class public API, so couldn't break binary compatibility.
@jvican
Copy link

jvican commented Oct 4, 2019

This is a good idea. It would be great if we could tweak private to private[$package] so that library authors can still use unapply and copy internally inside their library if they want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvican @alexarchambault