Recognise alternative let-like formats

[vemv]

Brief

The following vars:

compliment/src/compliment/sources/local_bindings.clj

Lines 6 to 13 in a112bb8

	(def let-like-forms '#{let if-let when-let if-some when-some loop with-open
	dotimes with-local-vars})
	(def defn-like-forms '#{defn defn- fn defmacro})
	(def doseq-like-forms '#{doseq for})
	(def letfn-like-forms '#{letfn})

represent closed sets and typically only will work over clojure.core symbols. So if one uses e.g. my/let, completion accuracy will degrade.

Proposal

In:

compliment/src/compliment/sources/local_bindings.clj

Line 55 in a112bb8

(cond (let-like-forms (first form))

Instead of doing (first form) (which will return let, my/let, etc), perform (-> form first name symbol). This way let-like-forms will work as usual, but also admitting alternative mechanisms that share the name but use a different namespace.

Same for defn, doseq, letfn.

Alternatives

Consumers could use alter-var-root! over the mentioned vars, although that doesn't seem a clean thing to do (and would also have to account for different ns aliases: my/let, com.domain.my/let, etc - which is not a closed set)

Thanks - V

[alexander-yakushev]

Hi, could you please check #77 first? Would it perhaps be enough if I merged something like that?

[vemv]

#77

[alexander-yakushev]

Actually, I agree with your point that it makes sense having it "for free" for symbols that have names exactly like let and defn. I mean, what's the worst that can happen? We guard ourselves against errors already, so at worst we might suggest some redundant locals within such macros, whatever.

I'll keep this open for now.

[vemv]

Ok nice!

I have a patch around, should be at hand