Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Recording #49

Open
LukeIGS opened this issue Nov 18, 2021 · 3 comments · May be fixed by #51
Open

Video Recording #49

LukeIGS opened this issue Nov 18, 2021 · 3 comments · May be fixed by #51

Comments

@LukeIGS
Copy link

LukeIGS commented Nov 18, 2021

I'd like to be able to record video like in normal selenoid. Doing so will require attaching another container in the pod (probably only when enableVideo is requested as a cap).

Existing logic that drives this in selenoid
https://github.com/aerokube/selenoid/blob/68ce8aa754e473fe4c961178e5974edd337e625c/service/docker.go#L498-L546

Basically if the video cap is requested, create container and forward a bunch of context to it. Transposing this to a k8s approach doesn't look too bad to me (basically append the container in
https://github.com/alcounit/selenosis/blob/main/platform/kubernetes.go#L395-L432
in the event that the cap is requested)

I'm assuming video endpoints would need to be exposed on seleniferous since it doesn't seem to have them yet. Selenosis probably also should get new args for video container image and such.

Let me know if you have any concerns, or questions with this, or if I'm not noticing something important. I'm still familiarizing myself with these two code bases.

@alcounit
Copy link
Owner

Hi @LukeIGS

Let me know if you have any concerns, or questions with this, or if I'm not noticing something important. I'm still familiarizing myself with these two code bases.

I'm not interested in adding a video recording feature to this project.

@LukeIGS
Copy link
Author

LukeIGS commented Nov 23, 2021

Do you have any issues with me adding it or should i fork?

@alcounit
Copy link
Owner

Feel free to submit pr. Thanks.

@alcounit alcounit added feature request enhancement New feature or request selenosis and removed enhancement New feature or request labels Dec 17, 2021
@Castone22 Castone22 linked a pull request Apr 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants