mbxml.py missing some attributes for some elements.

[tombay]

I have just started using the python program whipper ( cone from morituri) .
I have noticed that some of the element and attribute list in mbxml.py are missing fields returned from a musicbrainsquery. This is seen by log.info reports of "uncaught attribute". I update mbxml.py to address these issues. I have also included a "diff" text showing the differences. I also noticed that there are log.info reports of "uncaught" (without the attribute). This happens where "reparsing" attribute-lists. (see the comment in parse_relation method ->
# We parse attribute-list again to get attributes that have both
# text and attribute values
These log messages occur because the reparsing is reporting errors for elements that have already been handled by the first pass through the relation entry. I think these are benign messages so I added a boolean logit to the end of parse_elements (default True) to log uncaught entries.
The "xml" file from url https://musicbrainz.org/ws/2/release/9b71c862-0737-47af-ac4a-4c61183c9588?inc=artists+artist-credits+recordings+discids+labels+recording-level-rels+work-rels+release-groups+work-level-rels+artist-rels demonstrates the issues.
I have attached mbxml.orig.py.txt mbxml.new.py.txt, mbxml.diff.txt and fv.xml.txt
fv.xml.txt
mbxml.diff.txt
mbxml.new.py.txt
mbxml.orig.py.txt

I have not done a pull (Just did a git clone) but can If you wish. I imagine that with these little issues nobody has worried %-)
Cheers
Tom

[alastair]

Thanks for the report! I've fixed these in #282 and #281

[tombay]

Thanks Alastair. I was getting around to it but am glad you did it. 😌 I was going through musicbrainz_mmd-2.0 before submitting but will leave well alone. I used to use EAC for my music ripping but recently discovered Whipper. It makes use of the music brain API. Good to be able to have a Linux based open source system at last 😀. Ciao Tom. ⁣Get BlueMail for Android ​

On 17 Jan 2022, 7:01 am, at 7:01 am, Alastair Porter ***@***.***> wrote: Thanks for the report! I've fixed these in #282 and #281 -- Reply to this email directly or view it on GitHub: #276 (comment) You are receiving this because you authored the thread. Message ID:

***@***.***>