-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browse_recordings: not able to force additional information using includes-argument #192
Comments
It looks like musicbrainz doesn't return this information: I'm confirming the issue with them now. In the case that it's not supported we should probably prevent these includes from being used. |
I would only disallow the includes if the server doesn't allow them (or deprecates them as "not intended"). |
None of the recordings in the response posted have any release or release-group relationships, so there's no bug that I can see, except maybe clarifying the documentation. Check out https://musicbrainz.org/ws/2/recording/?artist=32bad879-c2fa-4da3-b06a-ac1fcd380c55&inc=release-rels&limit=100&offset=100&fmt=json and you can see a "samples material" release relationship for the recording "Wolf Rotorvator" is included, so the inc params definitely work. About release-group-rels, currently no recording-release_group relationship types exist: https://musicbrainz.org/relationships/recording-release_group But I don't think it makes sense to disallow inc=release-group-rels, for instance, because we might add a recording-release_group relationship type in the future, and it would break existing code that expects a generic way to get every relationship. I guess what I would do is link to https://musicbrainz.org/relationships in the documentation and explain that the inc parameters only have an effect where relationship types (and relationships) actually exist. |
Neither
release-rels
norrelease-group-rels
as part of the includes argument has effects on the output. Each recording entry provides only title and id-attributes:Full log:
The text was updated successfully, but these errors were encountered: