Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement collection add/delete methods #175

Open
JonnyJD opened this issue Jul 21, 2015 · 8 comments
Open

implement collection add/delete methods #175

JonnyJD opened this issue Jul 21, 2015 · 8 comments
Milestone

Comments

@JonnyJD
Copy link
Collaborator

JonnyJD commented Jul 21, 2015

The type of a collection was implemented in #170 and we can work with collections of releases.
After the implementation for events is complete (#168) we should also implement handling of collections of events. (blocked by #168)

There are some comments about this in #170.

@alastair
Copy link
Owner

Ian also implemented get works, and it's live on beta. No work submission though. Is there a event submit api yet?

@JonnyJD
Copy link
Collaborator Author

JonnyJD commented Jul 21, 2015

No clue actually. I don't follow server development closely ATM.

@alastair alastair modified the milestone: 0.6 Nov 15, 2015
@alastair
Copy link
Owner

alastair added a commit that referenced this issue Dec 29, 2015
alastair added a commit that referenced this issue Dec 29, 2015
@alastair alastair changed the title implement get_events_in_collection() implement collection add/delete methods Mar 16, 2016
@alastair alastair modified the milestones: 0.7, 0.6 Mar 16, 2016
@mineo
Copy link
Collaborator

mineo commented Oct 2, 2016

Both upstream tickets have been fixed.

@fin0
Copy link

fin0 commented Jun 7, 2017

Any chance that this is implemented soon (I need it for works :) )?

@mineo
Copy link
Collaborator

mineo commented Jun 7, 2017

Unfortunately I think none of the usual suspects is going to implement this in the near future :( If you feel like implementing it on your own, you can probably just copy&paste https://github.com/alastair/python-musicbrainzngs/blob/master/musicbrainzngs/musicbrainz.py#L1324-L1337 and replace releases with the names of the entity types that can be put into collections.

@fin0
Copy link

fin0 commented Jun 7, 2017

Worked out fine, thank you very much! :)

@mineo
Copy link
Collaborator

mineo commented Jun 11, 2017

@fin0 Would you mind submitting a pull request for those changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants