Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pebble and Anki #1

Open
pomkos opened this issue May 20, 2015 · 7 comments
Open

Pebble and Anki #1

pomkos opened this issue May 20, 2015 · 7 comments

Comments

@pomkos
Copy link

pomkos commented May 20, 2015

Hello,

Someone directed me to your Anki-Pebble project from here. Are you guys planning on releasing the app? I know I am highly interested in Anki on my Pebble, and I'm not alone!

@hallfox
Copy link
Collaborator

hallfox commented May 21, 2015

The app currently "works" only with a modified version of the Anki Android app. We would have released it if it didn't require modifying the Android app. The source code for Ishi is obviously here, but the modified app exists on my computer. I'm going to push it to my fork of Anki Android and you can have a look if you like.

@alanplotko
Copy link
Owner

@hallfox, how's the Android app code for Ishi? Can we make a pull request or perhaps seek guidance from the devs over at Anki Android?

@hallfox
Copy link
Collaborator

hallfox commented May 21, 2015

I'm almost positive the current modifications we made would not jive with the main developers of Anki Android. They're most certainly going to want us to change things, plus there were several other issues during development that need to be solved.

Our primary goal should be figuring out how to get our code to comply with Anki Android's code. @alanplotko , can you try to contact them?

@alanplotko
Copy link
Owner

@hallfox, check out this link about submitting improvements. We should do some unit testing to see if our added code breaks any of their provided cases and, of course, polish up the code. It seems that we can just make a pull request, but then again, this is an entirely new feature and not just a simple improvement. We should just create a thread on the support forum here.

Can I introduce ourselves and link to Ishi on the forum or would you like the honor of doing so?

@hallfox
Copy link
Collaborator

hallfox commented May 21, 2015

Please do that. I'm working on getting our modifications available.

@alanplotko
Copy link
Owner

Okay, I posted a topic (it needs to get approved by the forum mods first).

We should also pull any new code from the develop branch on AnkiDroid's repo to make sure there are no changes that will affect Ishi.

We should also look into publishing the Pebble App (perhaps after polishing it and once a pull request is accepted).

@hallfox
Copy link
Collaborator

hallfox commented May 21, 2015

I just did. Let's move this discussion somewhere outside the issue log. I'll make a gitter for Ishi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants