Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to TOML for configuration file #6592

Closed
chrisduerr opened this issue Dec 28, 2022 · 56 comments · Fixed by #6673
Closed

Switch to TOML for configuration file #6592

chrisduerr opened this issue Dec 28, 2022 · 56 comments · Fixed by #6673

Comments

@chrisduerr
Copy link
Member

I'm quite honestly tired of looking at YAML files with broken indentation. While YAML is an awful format even for experienced users, clearly it's completely impossible for inexperienced ones to grasp its concept. And the documentation of our configuration file with everything commented out by default probably doesn't help.

Since as far as I know all previous issues with TOML have been fixed and escape sequences can be easily specified in TOML strings now, I think it would make sense to switch to TOML as our default format.

In a transitory period we could probably get away with just loading existing YAML files and writing them out as TOML, to allow for backward compatibility. This will probably produce somewhat messy TOML files, but I can't imagine an auto-generated TOML file would be much worse than a YAML file.

The only major drawbacks I see is that this is a rather big change that will no doubt annoy a bunch of people and some more advanced features of YAML (like anchors) are not supported in TOML. But nobody really needs anchors and I kinda like annoying people.

@kchibisov You proposed this a while ago on IRC, do you think this is a bad idea?

See #1217 for prior discussions.

@kchibisov
Copy link
Member

@kchibisov You proposed this a while ago on IRC, do you think this is a bad idea?

I do like toml more. In general what we can do is to have support for both at the same time with a warning to do a conversion with some alacritty flag. But having both at the same time doesn't sound like fun to maintain.

I do wonder how stuff like multiple bindings will end up working.

Since as far as I know all previous issues with TOML have been fixed and escape sequences can be easily specified in TOML strings now, I think it would make sense to switch to TOML as our default format.

Is that supported by serde at least? Though, patching shouldn't be a problem.

chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Feb 4, 2023
This switches Alacritty's default configuration format from toml to
yaml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

TODO:
 - Migrate alacritty.yml
    => Might want to reconsider defaults being commented out?
 - Write/Test an `alacritty migrate` tool which converts the
   configuration file for the user

Closes alacritty#6592.
chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Feb 10, 2023
This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

TODO:
 - Migrate alacritty.yml
    => Might want to reconsider defaults being commented out?
 - Write/Test an `alacritty migrate` tool which converts the
   configuration file for the user

Closes alacritty#6592.
@keltia
Copy link

keltia commented Mar 13, 2023

HCL is also a good if not better choice.

chrisduerr added a commit to chrisduerr/alacritty that referenced this issue May 28, 2023
This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

TODO:
 - Migrate alacritty.yml
    => Might want to reconsider defaults being commented out?
 - Write/Test an `alacritty migrate` tool which converts the
   configuration file for the user

Closes alacritty#6592.
chrisduerr added a commit to chrisduerr/alacritty that referenced this issue May 30, 2023
This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

TODO:
 - Migrate alacritty.yml
    => Might want to reconsider defaults being commented out?
 - Write/Test an `alacritty migrate` tool which converts the
   configuration file for the user

Closes alacritty#6592.
chrisduerr added a commit to chrisduerr/alacritty that referenced this issue Jun 11, 2023
This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

TODO:
 - Migrate alacritty.yml
    => Might want to reconsider defaults being commented out?
 - Write/Test an `alacritty migrate` tool which converts the
   configuration file for the user

Closes alacritty#6592.
chrisduerr added a commit that referenced this issue Jun 12, 2023
This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

A new `alacritty migrate` subcommand has been added which allows
automatic migration from yaml to toml. This also could be used as a
facility to automatically fix configuration file changes in the future.

Closes #6592.
@skyfaller
Copy link

Aw man, I use anchors heavily in my Alacritty yaml config, for changing themes with scripting. I'm not quite sure what the best way to do this with TOML is. Do you have any suggestions for rewriting something like this in TOML?

schemes:
  # Colors (Blood Moon)
  blood_moon: &dark
    # Default colors:
    primary:
      background: '#10100E'
      foreground: '#C6C6C4'

    # Normal colors:
    normal:
      black:   '#10100E'
      red:     '#C40233'
      green:   '#009F6B'
      yellow:  '#FFD700'
      blue:    '#0087BD'
      magenta: '#9A4EAE'
      cyan:    '#20B2AA'
      white:   '#C6C6C4'

    # Bright colors:
    bright:
      black:   '#696969'
      red:     '#FF2400'
      green:   '#03C03C'
      yellow:  '#FDFF00'
      blue:    '#007FFF'
      magenta: '#FF1493'
      cyan:    '#00CCCC'
      white:   '#FFFAFA'

  # Colors (Terminal.app Basic)
  terminal_app_basic: &light
    primary:
      background: '#FFFFFF'
      foreground: '#000000'
    normal:
      black:      '#000000'
      red:        '#990000'
      green:      '#00A600'
      yellow:     '#999900'
      blue:       '#0000B2'
      magenta:    '#B200B2'
      cyan:       '#00A6B2'
      white:      '#BFBFBF'
    bright:
      black:      '#666666'
      red:        '#E50000'
      green:      '#00D900'
      yellow:     '#D0D000'
      blue:       '#0000FF'
      magenta:    '#E500E5'
      cyan:       '#00E5E5'
      white:      '#E5E5E5'

  # Colors (Oceanic Next)
  oceanic_next: &blue
    # Default colors:
    primary:
      background: '#1b2b34'
      foreground: '#d8dee9'

    # Colors the cursor will use if `custom_cursor_colors: ` is true
    cursor:
      text: '#1b2b34'
      cursor: '#ffffff'

    # Normal colors:
    normal:
      black:   '#343d46'
      red:     '#EC5f67'
      green:   '#99C794'
      yellow:  '#FAC863'
      blue:    '#6699cc'
      magenta: '#c594c5'
      cyan:    '#5fb3b3'
      white:   '#d8dee9'

    # Bright colors:
    bright:
      black:   '#343d46'
      red:     '#EC5f67'
      green:   '#99C794'
      yellow:  '#FAC863'
      blue:    '#6699cc'
      magenta: '#c594c5'
      cyan:    '#5fb3b3'
      white:   '#d8dee9'

# Colors (Gruvbox light)
  gruvbox_light: &yellow
    # Default colors:
    primary:
      # hard contrast: background = '#f9f5d7'
      background: '#fbf1c7'
      # soft contrast: background = '#f2e5bc'
      foreground: '#3c3836'

    # Normal colors:
    normal:
      black:   '#fbf1c7'
      red:     '#cc241d'
      green:   '#98971a'
      yellow:  '#d79921'
      blue:    '#458588'
      magenta: '#b16286'
      cyan:    '#689d6a'
      white:   '#7c6f64'

    # Bright colors:
    bright:
      black:   '#928374'
      red:     '#9d0006'
      green:   '#79740e'
      yellow:  '#b57614'
      blue:    '#076678'
      magenta: '#8f3f71'
      cyan:    '#427b58'
      white:   '#3c3836'

  # Colors (Tango)
  tango: &green
    primary:
      background: '#000000'
      foreground: '#00ff00'

    # Normal colors:
    normal:
        black:   '#2e3436'
        red:     '#cc0000'
        green:   '#73d216'
        yellow:  '#edd400'
        blue:    '#3465a4'
        magenta: '#75507b'
        cyan:    '#06989a'
        white:   '#d3d7cf'

    # Bright colors:
    bright:
        black:   '#2e3436'
        red:     '#ef2929'
        green:   '#8ae234'
        yellow:  '#fce94f'
        blue:    '#729fcf'
        magenta: '#ad7fa8'
        cyan:    '#34e2e2'
        white:   '#eeeeec'

  # Colors (Monokai Soda)
  monokai_soda: &purple
    # Default colors:
    primary:
      background: '#1a1a1a'
      foreground: '#c4c5b5'

    # Normal colors:
    normal:
      black:   '#1a1a1a'
      red:     '#f4005f'
      green:   '#98e024'
      yellow:  '#fa8419'
      blue:    '#9d65ff'
      magenta: '#f4005f'
      cyan:    '#58d1eb'
      white:   '#c4c5b5'

    # Bright colors:
    bright:
      black:   '#625e4c'
      red:     '#f4005f'
      green:   '#98e024'
      yellow:  '#e0d561'
      blue:    '#9d65ff'
      magenta: '#f4005f'
      cyan:    '#58d1eb'
      white:   '#f6f6ef'

  # Colors (Darkside)
  darkside: &red
    primary:
      background: '#222324'
      foreground: '#BABABA'

    # Normal colors
    normal:
      black:    '#000000'
      red:      '#E8341C'
      green:    '#68C256'
      yellow:   '#F2D42C'
      blue:     '#1C98E8'
      magenta:  '#8E69C9'
      cyan:     '#1C98E8'
      white:    '#BABABA'

    # Bright colors
    bright:
      black:    '#666666'
      red:      '#E05A4F'
      green:    '#77B869'
      yellow:   '#EFD64B'
      blue:     '#387CD3'
      magenta:  '#957BBE'
      cyan:     '#3D97E2'
      white:    '#BABABA'

  dracula: &lavender
    primary:
      background: '0x282a36'
      foreground: '0xf8f8f2'
    cursor:
      text: CellBackground
      cursor: CellForeground
    vi_mode_cursor:
      text: CellBackground
      cursor: CellForeground
    search:
      matches:
        foreground: '0x44475a'
        background: '0x50fa7b'
      focused_match:
        foreground: '0x44475a'
        background: '0xffb86c'
      bar:
        background: '0x282a36'
        foreground: '0xf8f8f2'
    line_indicator:
      foreground: None
      background: None
    selection:
      text: CellForeground
      background: '0x44475a'
    normal:
      black:   '0x000000'
      red:     '0xff5555'
      green:   '0x50fa7b'
      yellow:  '0xf1fa8c'
      blue:    '0xbd93f9'
      magenta: '0xff79c6'
      cyan:    '0x8be9fd'
      white:   '0xbfbfbf'
    bright:
      black:   '0x4d4d4d'
      red:     '0xff6e67'
      green:   '0x5af78e'
      yellow:  '0xf4f99d'
      blue:    '0xcaa9fa'
      magenta: '0xff92d0'
      cyan:    '0x9aedfe'
      white:   '0xe6e6e6'
    dim:
      black:   '0x14151b'
      red:     '0xff2222'
      green:   '0x1ef956'
      yellow:  '0xebf85b'
      blue:    '0x4d5b86'
      magenta: '0xff46b0'
      cyan:    '0x59dffc'
      white:   '0xe6e6d1'

# Dark options: dark,green,purple,blue,red,lavender
# Light options: light,yellow
colors: *light
# To change color theme using sd, try:
# sd '^colors: *.*$' 'colors: *light' ~/.config/alacritty/alacritty.yml
# I've also defined a fish function "theme-alacritty"

@kchibisov
Copy link
Member

@skyfaller use imports.

@skyfaller
Copy link

Thank you for the tip. For anyone who needs more detail on imports, some documentation: https://github.com/alacritty/alacritty/blob/master/extra/man/alacritty.5.scd#general

Any chance you could show some examples of how imports are used? Is there a sample config file somewhere?

@chrisduerr
Copy link
Member Author

chrisduerr commented Jun 12, 2023

If you're looking for toml syntax docs, you can find array docs here: https://toml.io/en/v1.0.0#array

Other than that it's just exactly as documented in the manpage. I strongly recommend looking at the raw text of the manpage, the markdown rendering is pretty screwed up (it strips the type from the array for example).

@pi-rho
Copy link

pi-rho commented Jun 19, 2023

Is it hard to support both? TOML pokes me in the eye while YAML is super comfy. Everyone has their preferences. Can't serde shield Alacritty and allow users to pick their favorite?

@kchibisov
Copy link
Member

@pi-rho you better not know how many issues we've got because option is not working and broken indention with yml, it's not fun to spend our time on trouble shooting them, with toml we warn on unused keys and you don't have to deal with indention, and you really don't have to deal with configuring alacritty that much anyway. It's true that generated config might be a bit off, but hand written ones are not that bad.

@pi-rho
Copy link

pi-rho commented Jun 19, 2023

That may be so, but this is where I'm at today. ;)

diff --git i/alacritty/src/config/mod.rs w/alacritty/src/config/mod.rs
index 821e9b6b..312b8828 100644
--- i/alacritty/src/config/mod.rs
+++ w/alacritty/src/config/mod.rs
@@ -228,7 +228,7 @@ pub fn deserialize_config(path: &Path) -> Result<Value> {
     // Convert YAML to TOML as a transitionary fallback mechanism.
     let extension = path.extension().unwrap_or_default();
     if (extension == "yaml" || extension == "yml") && !contents.trim().is_empty() {
-        warn!("YAML config {path:?} is deprecated, please migrate to TOML");
+        //warn!("YAML config {path:?} is deprecated, please migrate to TOML");

         let value: serde_yaml::Value = serde_yaml::from_str(&contents)?;
         contents = toml::to_string(&value)?;

@chrisduerr
Copy link
Member Author

Sooner or later support for YAML will be dropped. There is no reason why we'd maintain both and even the current YAML implementation is just a subpar fill-in for the transition period.

@nickeb96
Copy link

Do I need to do something specific to enable the TOML escape sequences mentioned above? I'm getting an error when I try to use them:

[8215.690349958s] [ERROR] [alacritty_config_derive] Unable to load config
Config error: TOML parse error at line 122, column 12
    |
122 | chars = "\e[13;2u"
    |            ^
invalid escape sequence
expected `b`, `f`, `n`, `r`, `t`, `u`, `U`, `\`, `"`

@chrisduerr
Copy link
Member Author

\e is not supported in TOML (yet). You need to use \u001b instead.

Both \e and \x1b will be supported with the next TOML release.

@bluz71
Copy link

bluz71 commented Jun 23, 2023

And the documentation of our configuration file with everything commented out by default probably doesn't help.

Can an alacritty.toml be created in this base of this repository mimicking the previous alacritty.yml file? That is with all options listed and mostly commented out?

I can't tell how many times I referred to that file to tweak a setting here and there.

That document was the document I referred to as the configuration source of truth. Now I feel lost.

@kchibisov
Copy link
Member

That document was the document I referred to as the configuration source of truth. Now I feel lost.

But you have man page now with all the options? And a separate for all default bindings.

@bluz71
Copy link

bluz71 commented Jun 23, 2023

Ok, I had a look now. The alacritty.5 man page has the information, so that is good to know it exists somewhere.

I don't think it is quite is quick and easy as the previous alacritty.yml example/instance file. But opinions will vary.

Thanks for the knowledge.

@kchibisov
Copy link
Member

But you can type man 5 alacritty in your terminal and have all the docs without a need to go on a github.com, because config before wasn't shipped even.

@Lucksinia
Copy link

...I am sorry for opening this one, but No manual entry for alacritty in section 5?

But you can type man 5 alacritty in your terminal and have all the docs without a need to go on a github.com, because config before wasn't shipped even.

@kchibisov
Copy link
Member

I am sorry for opening this one, but No manual entry for alacritty in section 5?

if you've built from source build man pages as well, no stable release was made with toml yet.

@pi-rho
Copy link

pi-rho commented Jul 5, 2023

my eyes are bleeding

[[keyboard.bindings]]
action = "ClearSelection"
key = "C"
mode = "Vi|~Search"
mods = "Control|Shift"

[[keyboard.bindings]]
action = "PasteSelection"
key = "Insert"
mods = "Shift"

[[keyboard.bindings]]
action = "ResetFontSize"
key = "Key0"
mods = "Control"

[[keyboard.bindings]]
action = "IncreaseFontSize"
key = "Equals"
mods = "Control"

:)

@kchibisov
Copy link
Member

@pi-rho

you're free to format the config however you want, you can use something like that

[keyboard]
bindings = [
  { key = "C", mods = "Control|Shift", mode = "Vi|Search", action = "ClearSelection" },
  { key = "Insert", mods = "Shift", action = "Paste" }
]

@cy8aer
Copy link

cy8aer commented Jul 16, 2023

It would be nice to have an example toml now because you are not able to prepare a color scheme based theming without the knowledge how to transform it from yaml. Migration makes the new toml unfunctional for example.

MaxAtoms added a commit to MaxAtoms/tokyo-night-alacritty-theme that referenced this issue Jan 9, 2024
Alacritty has switched to TOML.
See: alacritty/alacritty#6592
MaxAtoms added a commit to MaxAtoms/tokyo-night-alacritty-theme that referenced this issue Jan 9, 2024
Alacritty has switched to TOML.
See: alacritty/alacritty#6592
gtback added a commit to gtback/dotfiles that referenced this issue Jan 12, 2024
Alacritty now uses a TOML configuration file rather than YAML
(alacritty/alacritty#6592).

Also, move to a directory-based approach that uses XDG_CONFIG_HOME
(which alacritty supports) rather than symlinking directly into the home
directory.

After merging in this change, run `rm ~/.alacritty.yml` to clean up the
now-unused config file.
fnichol added a commit to fnichol/dotfiles that referenced this issue Jan 18, 2024
bhalash added a commit to bhalash/dotfiles that referenced this issue Jan 30, 2024
@J-MR-T
Copy link

J-MR-T commented Feb 1, 2024

I am so sick and tired of things always changing and breaking on me.

Then don't use software in beta? Is that such a difficult concept to grasp?

The readme says

The software is considered to be at a beta level of readiness; there are a few missing features and bugs to be fixed

not

The software is considered to be at a beta level of readiness; we "kinda like annoying people" so be prepared to be annoyed.


To be clear, I don't even question the migration itself, breaking changes are sometimes beneficial or even required; personally, I also don't mind migrating some alacritty config files once per year, but this comment really threw me off.

TL;DR: I don't like using software that wants to annoy me.

@bluz71
Copy link

bluz71 commented Feb 2, 2024

I found the migration simple and effective, a small amount of customization later, 10 mins all in all. Easy-peasy.

I suspect there is a silent majority where that is the case.

I am pleased with the change, TOML is a far better config format in comparison to YAML.

@J-MR-T
Copy link

J-MR-T commented Feb 2, 2024

As I said, I don't question this migration itself. I question the attitude of liking to annoy people.

Side note, I'm sure you could read the comment about annoying people as a joke, but even if it was, that sort of joke only works, if there is a kernel of truth to it.

@aarav2you
Copy link

HCL is also a good if not better choice.

Unfortunately your opinion is flat out wrong

@zeionara
Copy link

zeionara commented Feb 17, 2024

That may be so, but this is where I'm at today. ;)

diff --git i/alacritty/src/config/mod.rs w/alacritty/src/config/mod.rs
index 821e9b6b..312b8828 100644
--- i/alacritty/src/config/mod.rs
+++ w/alacritty/src/config/mod.rs
@@ -228,7 +228,7 @@ pub fn deserialize_config(path: &Path) -> Result<Value> {
     // Convert YAML to TOML as a transitionary fallback mechanism.
     let extension = path.extension().unwrap_or_default();
     if (extension == "yaml" || extension == "yml") && !contents.trim().is_empty() {
-        warn!("YAML config {path:?} is deprecated, please migrate to TOML");
+        //warn!("YAML config {path:?} is deprecated, please migrate to TOML");

         let value: serde_yaml::Value = serde_yaml::from_str(&contents)?;
         contents = toml::to_string(&value)?;

Thank you! I despise the TOML format. It is pain to read and edit the text. No other option than to disable the annoying warning in source.

Are there really people who think TOML is better than YAML? Why do you believe so?

In any case, I would be happy if you don't stop supporting YAML format

@ikouchiha47
Copy link

Which is fine. migrating to toml. But I hope I find a migration tool from yaml to toml. I mean I have had my dotfiles there for nearly half a decade now. Only change was for neovim. But then it was an eniterly different thing. Who is going to change the config manually now. Its easier to just find another terminal. 😆

@chrisduerr
Copy link
Member Author

If only Alacritty devs had integrated an automatic migration tool specifically built to ease this transition for existing users.

@anonhostpi
Copy link

anonhostpi commented Feb 29, 2024

I don't understand the practice of not supporting both config formats. Even moreso, deprecating a defacto standard.

Even if you are running into the problem of "too many indentation issues," then write a better SEO-optimized wiki, or add the problem to the issue template. It shouldn't take a lot of effort to educate end users on the defacto standard for configuration files.

Hell, you probably don't need to do more than update the issue template, because there are plenty of free education tools for YAML. Even linking a simple YAML validator in the issue template (and the installation docs) like https://www.yamllint.com/ should fix the original problem statement.

I will say that adding and switching the default configuration language to toml does make sense, because of the aforementioned better support for character escaping, but fully deprecating yaml does not.

You can't really justify deprecation with "can't support" either, because yaml and toml are just wrappers for json. If you can support one of the 3 (yaml, toml, or json), your app can support the other 2.

You might justify it with "don't want to support," but even then that is resolved with the above statement "write a better SEO-optimized wiki, or add the problem to the issue template"

@kchibisov
Copy link
Member

Even if you are running into the problem of "too many indentation issues," then write a better SEO-optimized wiki, or add the problem to the issue template. It shouldn't take a lot of effort to educate end users on the defacto standard for configuration files.

No one ever reads, remember that, people who read don't have issues with any of that. Alacritty is also not a stable software, as in pre 1.0, so we don't have to bother with legacy, this is stated in README and it was like that for a long time. After 1.0 no one will ever change the config format.

I will say that adding and switching the default configuration language to toml does make sense, because of the aforementioned better support for character escaping, but fully deprecating yaml does not.

toml is much simpler to work with, where with yaml you have e.g. yaml hooks.

You might justify it with "don't want to support," but even then that is resolved with the above statement "write a better SEO-optimized wiki, or add the problem to the issue template"

again, no one ever reads any of that, even with TOML all the docs are right there with examples and such, yet no one ever reads and asks ChatGPT or says on issues tracker how bad we are.

Also, keep in mind that unless someone rewrites serde(rust library for serialization) none of that is an easy task, because you have to convert between formats, and you can't convert yaml hooks at all, so you have to develop 2 internal reprs for all of that, which is just a madness and no-one has time for that thing (if you have go ahead and write serde alternative in rust for us, though by this point we'll sunset yaml config all together).

@anonhostpi
Copy link

anonhostpi commented Feb 29, 2024

The problem is that eventually, once Alacritty matures, this deprecated feature will turn right back into a feature request, since YAML is more widely adopted.

Also, "simple" is subjective. As you can see from the above, people will have complaints about TOML as well as YAML. People who are comfortable programming in Python and writing microservices (e.g. docker, gh-actions, etc) are going to find YAML simpler than TOML. People who deal with OS configuration files regularly are going to find TOML simpler than YAML. Using "simpler" or "better" when it comes to describing 2 languages that do the same things nearly identically is futile.

What you said about Rust's support for serialization languages does make sense, but then you end up with the problem in my first sentence. By the time that Alacritty matures, it is likely that Rust will have more reliable support for serialization languages.

But that's not even the main problem. It is very likely that people are going to request adding it back before Rust fixes serde, just simply because of it's wider adoption, end-user preference, and established precedence. As you said, people are going to continue to ignore the docs, and just use copilot/gpt-generated files to install your software, which are all going to tell them to use YAML. So, instead of getting "YAML indentation" issue-spam, you're going to get "why is yaml deprecated?"/"FR: add YAML" issue-spam.

@chrisduerr
Copy link
Member Author

The problem is that eventually, once Alacritty matures, this deprecated feature will turn right back into a feature request

How is this a problem? There will always be a bunch of garbage feature requests, rejecting them is not an issue.

What you said about Rust's support for serialization languages does make sense, but then you end up with the problem in my first sentence. By the time that Alacritty matures, it is likely that Rust will have more reliable support for serialization languages.

This just demonstrates lack of knowledge of the Rust ecosystem.

So, instead of getting "YAML indentation" issue-spam, you're going to get "why is yaml deprecated?"/"FR: add YAML" issue-spam.

So instead of hunting bugs in user configs we can just close issues immediately. I don't see how this isn't an easy win.

@anonhostpi
Copy link

anonhostpi commented Mar 2, 2024

The problem is that eventually, once Alacritty matures, this deprecated feature will turn right back into a feature request

How is this a problem? There will always be a bunch of garbage feature requests, rejecting them is not an issue.

So is rejecting "indentation issues"

What you said about Rust's support for serialization languages does make sense, but then you end up with the problem in my first sentence. By the time that Alacritty matures, it is likely that Rust will have more reliable support for serialization languages.

This just demonstrates lack of knowledge of the Rust ecosystem.

I have doubts that it is an inaccurate statement based off the lifetimes of several other languages. Serialization is a basic language feature. I doubt that any language community isn't going to work towards adopting de facto serialization standards.

From what I understand from the Rust ecosystem is that they do intend to offer competent YAML support: https://docs.rs/serde_yaml/latest/serde_yaml/

So, instead of getting "YAML indentation" issue-spam, you're going to get "why is yaml deprecated?"/"FR: add YAML" issue-spam.

So instead of hunting bugs in user configs we can just close issues immediately. I don't see how this isn't an easy win.

You won't have to bug hunt yaml indentation problems, if you add yaml and toml linters to the issue template.

If an end user doesn't lint their own files, then don't troubleshoot. It doesn't matter if its YAML or TOML.

@chrisduerr
Copy link
Member Author

From what I understand from the Rust ecosystem is that they do intend to offer competent YAML support: https://docs.rs/serde_yaml/latest/serde_yaml/

Version 0.8 of this library was using yaml-rs, which was abandoned because yaml is an awful file format that you cannot write parsers for. Version 0.9 switched to a Rust translation of libyaml, a C Library that was abandoned 3 years ago and has numerous known security issues.

So since you're clearly an expert in this field, please tell me more about the plethora of amazing deserialization options for yaml. It's such a cool format, I'd love to learn about more popular Rust libraries supporting it.

@amne
Copy link

amne commented Apr 8, 2024

Docs say you can override shell with

[shell]
program="myshell"
args=["myargs","more"]

And then immediately after that it says working_directory is either a string or None but it's a root level field.
How do you parse this?

[shell]
program="myshell"
args=["myargs","more"]

working_directory="/home/whatever"

@kchibisov
Copy link
Member

How do you parse this?

The working directory ends up in the [shell] section, you should just put it above everything else.

@SidOfc
Copy link

SidOfc commented Apr 15, 2024

Hello all, at first I liked my yaml config and I found that the generated toml version looked a bit clunky (not trying to dunk on tools which convert my config file for essentially free, thank you for saving me time! <3).

So I went and found this issue because I was wondering about whether yaml support was actually being completely phased out (which seems to be desired by the OP). I figured the next best thing was to try and improve the readability of the toml file since that seems to be the way forward. I took a quick stroll through the specs which are actually remarkably easy to understand and came up with this version:

Honestly it's quite good, I think I'm liking this more than my yaml config actually :)
Nobody particularly "loves" changes like this but OP has done the work to provide a deprecation warning accompanied by tooling to automatically get to a working toml version. Technically Alacritty is still in "beta" as well so it shouldn't come as a surprise that some changes will still be made.

All this is just to say please try to understand the OP's reasoning, take 5 minutes to improve the generated toml file using info from the specs and enjoy the result knowing it's very likely here to stay.

Finally, my apologies if this adds just more noise to the conversation. Just wanted to share some thoughts since there were some small arguments going on in the conversation.

@chrisduerr
Copy link
Member Author

All this is just to say please try to understand the OP's reasoning, take 5 minutes to improve the generated toml file using info from the specs and enjoy the result knowing it's very likely here to stay.

There's no point in manually writing toml formatters to try and get it into a subjectively better format when there's no way we'll ever match exactly the way it should be either. I used the automated tool to get started, then cleaned it up by hand, if people have an issue with that they can write their own migration tool.

@SidOfc
Copy link

SidOfc commented Apr 15, 2024

That makes complete sense to me, I'm already happy about the fact that some simple conversion is included and just works. Taking a little bit of time to further refine automatically converted configuration is a small price to pay for what is in my opinion the best terminal out there.

Thanks for all your work!

@amne
Copy link

amne commented May 2, 2024

How do you parse this?

The working directory ends up in the [shell] section, you should just put it above everything else.

of course. but how do you get out of section and back to root level? is toml limited here?

@chrisduerr
Copy link
Member Author

of course. but how do you get out of section and back to root level? is toml limited here?

Yeah this can be a bit confusing for people new to toml. Hopefully #7908 will resolve this but unfortunately it has stalled (for now). I'd like to see that land in Alacritty's next stable release.

xiaogaozi added a commit to xiaogaozi/alacritty that referenced this issue May 24, 2024
* Bump development version to 0.13.0-dev

This is only an update to the development version and does not represent
a stable release.

* Update INSTALL.md Ubuntu instructions

* Add missing `ToggleMaximized` docs in the config

* Add `window.resize_increments` config option

Given how bugged the resize increments are on X11, it's better to
disable it by default.

* Relax horizontal scrolling

Apply horizontal scrolling when the angle between the axis X
and (x, y) vector is lower than 25 degrees.

Fixes alacritty#6711.

* Fix bracketed paste with EOT payload

This works around an issue in many (all?) shells where the bracketed
paste logic would only strip out `\r` but interpret EOT (`\x03`) as a
termination of the bracketed paste.

* Send D&D input through paste action

Treating D&D like paste allows using D&D to input text into areas other
than the PTY, like the search bar.

* Fix busy rendering when the same warning persists

When the same warning is thrown on the each rendering iteration, it'll
force alacritty to always render.

Co-authored-by: Christian Duerr <[email protected]>

* Bump winit to 0.28.2

This also bumps copypasta and sctk-adwaita.

Fixes alacritty#6744.
Fixes alacritty#6702.
Fixes alacritty#6696.
Fixes alacritty#2741.

* Bump x11-clipboard to v0.7.1

Fixes alacritty#6760.

* Use `thin` instead of `fat` LTO

The performance between `thin` and `fat` is in the margin of error,
however `thin` LTO is way faster to build.

* Improve fish completions installation instructions

Co-authored-by: Kirill Chibisov <[email protected]>

* Bump winit to 0.28.3

Fix macOS leak when closing the window.

* Fix `;` character in URI OSC 8 payload

The special character `;` can be not URL-encoded, thus it'll add
extra parameter in the payload. Handle it joining extra parameters
with the `;` as a separator.

* Bump CHANGELOG development version to 0.13.0-dev

This is only an update to the development version and does not represent
a stable release.

The original bump to 0.13.0-dev was made in 9cf2c89, but did not make
any changes to the changelog. This adds a 0.13.0-dev changelog entry to
master so new changes are properly added to the correct place.

* Fix selection rotation on the last line

This fixes an issue with terminal resizes when the selection is on the
last line. Alacritty would fail to rotate lines and keep the selection
in the same line index whenever the terminal line count was grown or
shrunk.

This issue occurred due to the range passed to the selection's rotate
function still being based on the old terminal size, which caused the
initial or target state of the rotation to be outside of the terminal
bounds.

Closes alacritty#6698.

* Add missing terminfo capabilities

This adds capabilities for focus in/out (XF, kxIN, kxOUT) and bracketed
paste (BD, BE, PE, PS).

* Reset char suppression for every key binding

Previously the character suppression was only reset whenever a key was
released. However this did not take key repetition into account.

Now every key down also resets the character suppression. This should
work since the `ReceivedCharacter` is always received immediately after
the `KeyboardInput` without the chance of a racing condition where
another keyboard event interrupts the two.

* Use paste for ESC action and IME commit

Route string terminal input through 'ActionContext::paste'
instead of char by char write improving performance by
utilizing bracketed paste mode when it's reasonable.

* Allow mode-exclusive bindings in any mode

This patch enables binding chains that go beyond mode changes by
allowing bindings to be defined for modes they do not usually have an
effect in.

* Omit urgency hint focused window

* Bump winit to 0.28.4

Fixes alacritty#6817.

* Add `ALACRITTY_EXTRA_LOG_TARGETS` env variable

This should help with troubleshooting the dependency crates like winit.

* Bump winit to 0.28.5

The 0.28.4 was yanked.

* Fix very long startup time on some Wayland systems

This is not a real fix for the issue given that dbus method sctk-adwaita
is using will being called anyway. The proper fix will be available
with the winit's 0.29.0 release.

Right now the delay reduced from around 20 seconds to 100ms on a
systems with broken xdg-desktop-portal setup.

* Bump `actions/checkout` to v3

Fix Node 12 deprecation warnings in action runs.

* Update glutin to 0.30.8 and winit to 0.28.6

Fixes alacritty#6920.
Fixes alacritty#6824.

* Fix upload from CI on windows

* Update bitflags to 2.2.1

* Update xdg and dirs crate

The recent version on xdg crate moved to home crate which is used
by cargo. Thus to query for home directory we can use the home
dependency instead which is smaller.

* Update clap to v4.2.7

Fixes alacritty#6879.
Fixes alacritty#6874.

* Update patch dependencies

* Improve renderer debuggability

Make the renderer more debuggable by adding extra logging and using
`GL_KHR_debug` when running with the debug log level.

* Add version 0.12.1 to CHANGELOG

* Switch to VTE's built-in ansi feature

Co-authored-by: Christian Duerr <[email protected]>

* Fix 216-color cube generation

This fixes a regression introduced in cb7ad5b which swapped the green
and blue values when constructing the 216-color RGB cube.

Fixes alacritty#6951.

* Fix hyperlink preview for 2 lines terminal (alacritty#6953)

The intention was to show it, however it was hidden due to wrong
comparisson check.

* Move manpages to scdoc

This rewrites the existing manpages to use the `scdoc` format, making it
simpler to read and edit the manpages without intricate roff knowledge.

Some minor changes to the manpages were made in the process, mostly
focusing on correcting some of the wording. The list of maintainers has
also changed to ensure people not involved in the project anymore aren't
unnecessarily contacted for support.

* Fix Makefile manpage generation

Signed-off-by: Dennis Maier <[email protected]>
Co-authored-by: Christian Duerr <[email protected]>

* Fix crash on ScaleFactorChange on Windows

Windows is known to send zero sizes from winit in Risezed and now
in ScaleFactorChanged events. They were handled in Resized, but
not in ScaleFactorChanged.

Fixes alacritty#6949.

* Bump dependencies

Co-authored-by: Christian Duerr <[email protected]>

* Add resolver to workspace manifest

This explicitly specifies resolver "2" in the root manifest, to fix a
warning introduced in a recent nightly release.

* Switch to TOML configuration format

This switches Alacritty's default configuration format from yaml to
toml. While yaml is still supported, it is done by converting it to toml
and should be removed entirely in the future.

All existing features were persisted based on my testing. Behavior
should not change much, though `--option` might have slightly different
behavior since the entire line is not interpreted as one line of toml.

A new `alacritty migrate` subcommand has been added which allows
automatic migration from yaml to toml. This also could be used as a
facility to automatically fix configuration file changes in the future.

Closes alacritty#6592.

* Change the way we refer to IRC chat

* Fix warnings for config imports

Closes alacritty#6996.

* Add option to persist hints after selection

Closes alacritty#6976.

* Fix `alacritty msg config` toml replacement

This fixes a regression introduced in bd49067 which broke the override
of configuration file variables using `alacritty msg config`.

To fix this the `replace` functionality was rewritten to behave more
like the `serde_utils::merge` where entire values are inserted into the
existing structure rather than separating the keys from the values.

Fixes: bd49067 (Switch to TOML configuration format)

* Fix freeze with some drivers when using GLX

Fixes alacritty#6972.

* Fix parsing of integer font sizes

Config file conversion broke parsing of the font size value if it's
written as an integer, since TOML integers are always signed.

* Add errors for deserializing with unknown fields

Currently there are still some places where `Deserialize` is used rather
than `ConfigDeserialize`, which means that the built-in warning for
unused fields is not emitted automatically.

To ensure users don't have invalid configurations, the
`#[serde(deny_unknown_fields)]` annotation has been added to these
structs, making it a hard error when an unknown field is present.

* Fix the crash when shrinking scrolled terminal

display_offset was adjusted unconditionally, thus it could go
beyound the history limits, so clamp it to history like we do
in grow_colums.

Fixes alacritty#6862.

* Add support for loading conpty.dll

Co-Authored-By: @fredizzimo
Co-Authored-By: @Grueslayer

* Update wix on the release CI

Fixes alacritty#6939.

* Add TOML migration recommendation to warning

This adds a little recommendation to use `alacritty migrate` to
automatically transition configuration files from YAML to TOML.

* Remove mouse double_click/triple_click options

Fixes alacritty#6962.

* Change the default colorscheme

The new colorscheme is base16 classic dark with the bright colors
generated with oklab toolkits. The base16 classic dark is less washed
out and represents the current maintainers preference. The motivation
to change it was subjective, though it does look like generic dark
theme.

On a side note, this colorscheme was used for alacritty.org web page for
a long time, however it used different foreground color.

* Add manpage links to "see also" section

* Add version 0.12.2 to CHANGELOG

This is only an update to the development version and does not represent
a stable release.

* Add a note in README about older versions

Unfortunately it's not clear to everyone that they are looking at the
development documentation.

* Fix legacy bindings taking precedence over new ones

They were compared by len, but it's was wrong from the start, since
a user provided binding could remove more than one builtin binding,
so it was impossible for users to use their own bindings.

The most reliable way to do so is to use `Option`, given that we fill
default during deserialization.

Fixes alacritty#7050.

* Update binding sections in config manpage

* Create man5 directory along with man1

* Update to the new winit keyboard API

The main highlight of this update is that alacritty will now use new
keyboard API from the winit, which resolves a lot of issues around
key bindings, such as ability to bind dead keys. It also fixes long
standing issues with the virtual key code bindings and make bindings
in general more predictable. It also makes our default Vi key bindings
fully working.

Given that alacritty was using `VirtualKey` directly in the bindings
from the winit, and winit simply removed the enum, we've added internal
conversions to minimize the fallout, but new way to specify the bindings
should be more intuitive.

Other part of this update fixes some forward compatibility bugs with the
Wayland backend, given that wayland-rs 0.30 is fully forward compatible.
The update also fixes weird Maximized startup issues on GNOME Wayland,
however they were present on any sane compositor.

Fixes alacritty#6842.
Fixes alacritty#6455.
Fixes alacritty#6184.
Fixes alacritty#5684.
Fixes alacritty#3574.
Fixes alacritty#3460.
Fixes alacritty#1336.
Fixes alacritty#892.
Fixes alacritty#458.
Fixes alacritty#55.

* Fix configuration link typo

Co-authored-by: Christian Duerr <[email protected]>

* Fix `window.option_as_alt=Both`

Fixes alacritty#7077.

* Unset `XDG_ACTIVATION_TOKEN` in alacritty_terminal

This variable is what being used for Wayland's activation stuff.

* Raise double click threshold to 400ms

This should improve the situation with some touchpads. GTK4 is also
using the same value.

* Prefer logical key for named keys

Some keyboard layouts have named logical keys via shift combinations
of some sorts. So prefer them.

Fixes alacritty#7076.

* Mention all the actions in the man page

A lot of actions were left without a notice, so the only way to figure
out some of them was to browse source code. An example of such
actions were `Maximize` and `Minimize`, since we don't have a binding
for them, so they were left even in alacritty-bindings(5).

Explicitly list all the bindings we have. The search bindings were
also not accurately restricted, since we allow them to be executed
inside regardless of mode.

* Use lowercase latters in bindings for h/m/l

They were using uppercase latters, however our config expects everything
as lowercase, because we're using `key_without_modifiers` +
`ModifiersState`.

* Remove unnecessary mutable references

* Fix license syntax

This patch updates the license field to follow the SPDX 2.1 license
expression standard.

* Use bracketed paste only for multi-char IME input

Some IME setups do only `commit` single char input, like fcitx5 when
doing ru input.

* Fix manpage docs for shell section

Closes alacritty#7087.

Co-authored-by: Kirill Chibisov <[email protected]>

* Fix keys like `+` not working on neo layouts

The key_without_modifier removes all the modifiers including the
multiple shift levels, which is not desired. In alacritty we
just wanted to treat uppercase and lowercase latters the same,
which we can with the help of builtin functions.

* Mention `Forward`/`Back` mouse buttons in man page

They were mentioned only in the changelog, but forgotten in the man
page.

* Add `terminal` config section to control OSCs 

Some environments demand certain OSC sequences to be disabled or
some escape sequence could require handling which is out of scope
of alacritty, but could be done by external script (OSC 777).

Added section for now just handles the `OSC 52` sequence and changes
its default to be `OnlyCopy`, which is handy for remote copy, but
`Paste` is redundant because normal `Paste` hotkey could be used as
well.

Fixes alacritty#3386.

Co-authored-by: Christian Duerr <[email protected]>

* Skip whitespaces for wide chars in preedit

While we skip the spacers for the wide characters in the grid due to
them having a proper flags, the draw_string method was generating the
cells with incorrect flags leading to wide chars being cut off.

* Make URL_REGEX more strict

* Use ahash instead of fnv and regular hash function

After evaluation of the ahash with the data alacritty uses it was
discovered that it's 1.5-2x times faster when getting the already
hashed values, which is the primary cases for alacritty's renderer.

Given that ahash is generally faster, all the HashSet and HashMap's
inside the alacritty were changed to use it as a hasher function.

* Ignore scrolling multiplier on touchscreens

* Apply transparent background colors to "UI" cells

* Copy global IPC options for new windows

This patch stores all options set for the Window ID `-1` and
automatically applies them to new windows after their creation.

This in theory makes it possible to have a fully dynamic "default
config" without having to reapply it for every new window.

Closes alacritty#7128.

* Fix decorations_theme_variant spelling in manpage

* Remove winit dependency from alacritty_config

* Update regex-automata to v0.3.6

This seems like a sensible first step before looking into alacritty#7097.

* Fix crash with anchored searches

While this does **not** enable the use of anchors (`^`) in user regexes,
it does prevent Alacritty from crashing when attempting to do so.

* Change `window.padding` from u8 to u16

Fixes alacritty#6900.

* Quote `None` consistently inside the man page

`None` must be inside the `"`, since it's a string value.

* Add examples to more sections

Some sections were provided without a default, so provide an example for
them.

* Update winit to 0.29.1-beta

Make use of new winit frame throttling mechanism used in RedrawRequested,
which removes the need for having Wayland queue to ask for the frame
callbacks.

Fixes alacritty#7011.

* Add bindings for macOS tabs

This doesn't represnet the movement to add tabs on any other platform,
unless winit could add a similar API for them.

* Support startup notify on Wayland/X11

Activate a window to indicate that we want initial focus when the
system uses startup notifications.

Fixes alacritty#6931.

* Add `prefer_egl` debug option

Some systems have rendering issues when using GLX rather than EGL. While this is
usually due to a driver bug, it is helpful to provide a workaround for this by
allowing people to prefer EGL over GLX.

This patch adds the new `debug.prefer_egl` option to provide this workaround.

Closes alacritty#7056.

* Remove obsolete ansicode.txt file

The wiki contains a list of links to ANSI references:
https://github.com/alacritty/alacritty/wiki/ANSI-References

* Test man-pages compilation on the CI

* Add missing position config docs

* Fix regex memory usage

This fixes an issue where regexes with a large number of possible states
would consume excessive memory, since the entire DFA was compiled ahead
of time.

To solve this, the DFA is now built at runtime using `regex-automata`'s
hybrid DFA.

There are however still some checks performed ahead of time, causing
errors with obscenely large regexes (`[0-9A-Za-z]{999999999}`), which
shouldn't cause any issues.

A regex which is large, but not large enough to fail the NFA
construction (like `[0-9A-Za-z]{999999}`) will cause a long search of
the entire grid, but will complete and show the match.

Closes alacritty#7097.

* Underline hint matches during selection

This patch underlines the full regex hint match while the keyboard hint
selection is in process.

While it would be possible to color the entire match, this would only
introduce unnecessary configuration options and be too noisy. The
underline matches the mouse highlighting and has a less drastic visual
impact.

Closes alacritty#6178.

* Bump VTE to 0.12.0

Fixes alacritty#6845.

* Update the escape_support.md for sync updates

Remove the DCS sync updates escape sequence since it's no longer
supported.

Fixes: 47d5007 (Bump VTE to 0.12.0)

* Port from mio to polling

This patch replaces the mio crate with the polling. Now that
smol-rs/polling#96 has been merged, we should be at full feature parity
with mio v0.6 now.

Fixes alacritty#7104.
Fixes alacritty#6486.

* Update dependencies

This patch applies all breaking and non-breaking dependency updates
and bumps MSRV to 1.70.0.

* Fix PTY being closed on creation

The PTY got closed because `OwnedFd` automatically closed it.

Fixes: 59c63d3 (Update dependencies)

* Fix regex matches ending on multiline

This fixes an issue where the reverse search for the regex start would
truncate a character when ending on a newline, since it was omitting the
EOI check in that case.

This also fixes a separate issue which caused regexes which capture
empty strings (e.g.: `.*`) to always report a match.

This is a regression introduced in 73276b6.

* Fix regex patterns allowing for empty strings

This patch changes the mode we search for patterns which allow an empty
string, by anchoring all searches. As a result we will match the longest
possible match when multiple patterns are present (like `;*|rust`),
instead of using the leftmost pattern only.

This is only possible with empty matches since our parser is reset on
every byte anyway, so anchoring the search makes no difference.

Fixes alacritty#7276.

* Use openpty-rustix instead of nix

Follow upstream libraries and use rustix to reduce the amount of
dependencies in the future.

Co-authored-by: Christian Duerr <[email protected]>

* Fix `window.decorations_theme_variant` reload

The live reload handling wasn't introduced when the option got added.

Fixes alacritty#7295.

* Add inline vi mode search

This patch adds inline search to vi mode using `f`/`F` and `t`/`T` as
default bindings. The behavior matches that of vim.

Fixes alacritty#7203.

* Bump rustix to 0.38.20

* Update winit to 0.29.2 and copypasta to 0.10.0

Fixes alacritty#7236.
Fixes alacritty#7201.
Fixes alacritty#7146.
Fixes alacritty#6848.
Fixes alacritty#3601.
Fixes alacritty#3108.
Fixes alacritty#2453.

* Fix crash due to wrong drop order of clipboard

Fixes alacritty#7309.

* Prefer exact matches for bindings in mouse mode

Only consider bindings without Shift if there are no actions defined for the
actual mouse event.

Closes alacritty#7292.

* Fix typos

* Add version 0.12.3 to CHANGELOG

This is only an update to the development version and does not represent
a stable release.

* Avoid maximizing window when creating new tab

This patch ignores the startup mode when creating a new tab on macOS to
avoid maximizing an existing window.

Co-authored-by: Christian Duerr <[email protected]>

* Fix clippy warnings

* Add `window.blur` config option

Fixes alacritty#972.

* Add man 5 pages to upload_asset.sh

They are compiled, but not being uploaded.

* Bump glutin to 0.31.1

This fixes a crash on startup with macOS Sonoma.

* Fix crash when leaving search after resize

This fixes a crash which could occur when leaving search with a visible
match after shrinking the terminal height to be lower than the original
line the focused match was in.

Closes alacritty#7054.

* Bump ahash to 0.8.6

* Remove `alacritty_config` from alacritty_terminal

There's no need to force alacritty's user configuration on
other users of the crate, thus provide the options actually used
by alacritty_terminal itself.

* Fix cursor being hidden after reaching timeout

The timeout and blink events could be delivered at the same time,
so canceling blinking won't work and we'll still have an event.

* Use builtin font to draw powerline symbols

In addition to box drawing it was decided to also draw powerline
symbols, since those are quite common and rather simple to draw with
present box drawing infra.

* Unify CLI config override mechanisms

This patch changes the way the `-o` config option works when specified
at startup to function the same way as the IPC mechanism.

While this should technically perform the exact same way, it should
hopefully make it a little easier to understand how CLI config
replacement works.

* Add `--option` argument to `create-window`

This patch adds a new CLI parameter to the `create-window` subcommand,
matching the existing `--option` parameter when creating a new Alacritty
instance.

This parameter allows setting up the initial window configuration from
the CLI without having to call `alacritty msg config`, making sure that
all options are set appropriately right from the start.

Closes alacritty#6238.

* Change default `bell.animation` to `Linear`

The default animation feels really choppy, but it's just how its
function looks.

* Fix visual bell getting stuck on macOS

Fixes alacritty#7325.

* Fix message bar damage

Fixes alacritty#7224.

* Fix Sync capability in terminfo

Alacritty has supported mode 2026 for synchornized updates for a few
months, but the terminfo entry still used the old DCS sequence
originally supported by iTerm2. Since many other terminal emulators and
applications seem to be standardizing around 2026, change the terminfo
entry to use SM instead of DCS.

* Fix Vi cursor not being dirty when scrolling

* Simplify powerline drawing algorithm

Iterate over points in line instead of drawing it right away
and then finding it in the buffer.

Fixes: 4a26667 (Use builtin font to draw powerline symbols)

* Add error handling for OpenGL connection details

* Update VTE to 0.13.0

* Add support for DECRPM/DECRQM

* Damage only terminal inside `alacritty_terminal`

The damage tracking was including selection and vi_cursor which were
rendering viewport related, however all the damage tracking inside
the `alacritty_terminal` was _terminal viewport_ related, meaning that
it should be affected by `display_offset`.

Refactor the damage tracking so `alacritty_terminal` is only tracking
actual terminal updates and properly applying display offset to them,
while `alacritty` pulls this damage into its own UI damage state.

Fixes alacritty#7111.

* Create only one branch per major release

Having a separate branch for each release makes it harder to maintain
without an actual benefit, since every release from the major version
is linear, so creating branches doesn't make any sense.

They also collapse with the tag names leading to ambiguous refs.

* Make sections the same case in man pages

* Fix SelectLastTab in alacritty-bindings(5)

* Make man pages look consistent

Part of the man pages were using _value_, other part were using just
value, thus make everything as _value_.

Also properly dot terminate and add spacing through out the man pages.

* Explicitly use `=` in alacritty(5)

This should help with understanding how to write TOML
without reading too much into specification.

* Improve section to TOML section refs

This should give more hints where to put things.

* Add example for [window] section in alacritty(5)

This should give a hint on how to generally tweak things.

* Drop repo link in *SEE ALSO* man sections

The alacritty documentation is fully present inside the man pages, the
repo provides nothing extra other than a way to report issues, which
lives in its own section anyway.

* Fix default for [[hints.enabled]] in man pages

The default was incomplete, since `command` was missing.

* Add migrate to alacritty(1)

* Damage entire window on font size change

Font size could change without changing the cell dimensions, like
becoming slightly higher/wider.

Fixes: 40160c5 (Damage only terminal inside `alacritty_terminal`)

* Fix IME popup positioning

When setting cursor area, the popup will be placed either above or
below not obscuring the supplied region, however we were still
offsetting line with `+1` putting the cursor at the bottom of the line,
and given that area is from the top-left corner, the wrong area
was marked for not being obscured.

It was also discovered that some compositors, like GNOME, position
IME in the bottom right corner of the supplied region, which is wrong,
but it renders IME popup not very useful, since it's far away from
the place it should be, thus try to not obscure just a few characters
near the cursor.

Given that X11 doesn't support area setting, it uses the old logic
with offsetting.

Co-developed-by: lilydjwg <[email protected]>
Signed-off-by: lilydjwg <[email protected]>

* Bump dependencies

Update dependencies with `cargo update` as well as do explicit update
of winit, crossfont, and regex-automata.

* Make AA stronger for undercurl

This improves undercurl rendering preserving its original thickness.
This also makes it look not out-of place when places next to other
lines.

* Document macOS shortcuts for search

* Adjust default Vi's SearchBackwards binding

We have the same policy with Shift for numbers.

* Fix DECRPM reporting

The DECRQM uses `p` to query, but the reply uses `y`.

Fixes alacritty#7397.

* Optimize undercurl shader

This removes the if and lowers amount of operations.

* Fallback to underline shader when dotted fails

Some hardware is just bad.

Fixes alacritty#7404.

* Don't use `::*` for enum variants in bindings

* Fix chars usage inside the mouse bindings

Fixes alacritty#7413.

* Implement kitty's keyboard protocol

The protocol enables robust key reporting for the applications, so
they could bind more keys and the user won't have collisions with
the normal control keys.

Links: https://sw.kovidgoyal.net/kitty/keyboard-protocol
Fixes alacritty#6378.

* Update to crossfont 0.6.0

* Fix trigger of normal bindings in mouse mode

We should ensure that the `Shift` is actually pressed when trying to
prefer regular bindings instead of the ones if we had Shift applied.

Fixes: 500b696 (Prefer exact matches for bindings in mouse mode)
Fixes alacritty#7415.

* Don't emit text for NamedKey without text repr

When the key doesn't have textual representation we shouldn't emit
the text for them, since they are processed via bindings.

Also, fix the logic to handle named keys with disambiguate without
special modes/modifiers.

Fixes alacritty#7423.

* Fix message bar not damaged when the same size

The regression was added due to `y` coordinate in OpenGL differs to
`y` inside the damage rectangles.

Fixes: 40160c5 (Damage only terminal inside `alacritty_terminal`)

* Bump crossfont to 0.7.0

* Alacritty version 0.13.0-rc1

* Add link to rendered config docs

This adds a link to alacritty.org's rendered configuration file
documentation.

* Fix the order of `ClearSelection` in Vi mode

Fixes alacritty#7438.

* Account for option_as_alt when doing kitty protocol

By default `Alt` is not a real `Alt` on macOS, so we shouldn't treat
it as a modifier.

Fixes alacritty#7443.

* Bump winit to 0.29.5

Fixes alacritty#7449.

* Keep IME always enabled on X11

Fixes alacritty#7195.

* Alacritty version 0.13.0-rc2

* Apply modifiers before presses in kitty protocol

While this doesn't handle releases with multiple identical modifiers
pressed, the release can't work reliable anyway, since one modifier
could be pressed before focusing the window, thus tracking modifiers
based on the keysym values won't work as it was suggested by kitty
author.

Links: kovidgoyal/kitty#6913

* Bump winit to 0.29.7

This also bumps other dependencies along the way.

Fixes alacritty#2886.

* Alacritty version 0.13.0

* Mark SimpleFullscreen as macOS only startup mode

* Derive `Clone` for `EventLoopSender`

* Fix `alacritty migrate` with nonexistent imports

Fixes alacritty#7473.

* Remove direct dependency on once_cell

With MSRV 1.70, std now contains the necessary parts.

* Use pre-composed key for `Alt` bindings on macOS

Fixes alacritty#7475.

* Fix inability to bind `Alt+Control` on Windows

Fixes alacritty#7506.

* Passthrough potential errors for `EventLoopSender`

* Don't substitute `\n` in char bindings

This broke unintentionally due to routing paste-like input
via paste function.

Fixes alacritty#7476.

* Send associated text for shifted numbers with kitty

Also fix the wrong ordering of base and shifted keys.

Fixes alacritty#7492.

* Powerline glyphs being cut for narrow fonts

Fixes alacritty#7470.

* Remove note about versions pre 0.13.0

* Bump winit to 0.29.8

Fixes alacritty#7514.
Fixes alacritty#7502.
Fixes alacritty#7494.
Fixes alacritty#7474.
Fixes alacritty#7472.

* Fix number-based mouse bindings

The toml migration introduced a regression which stopped numbered key
binding's from working. This patch implements the required number type
to make things work again.

Fixes alacritty#7527.

* Fix replacing optional fields

This fixes an issue with the default `SerdeReplace` implementation where
it would never recurse through options but always replace the entire
option with the new value.

Closes alacritty#7518.

* Add vi search paste bindings

Closes alacritty#7511.

* Ignore null values in `alacritty migrate`

This should help with broken YAML configurations by throwing nulls
away, which are not representable in toml.

* Bump winit to 0.29.9

Fixes alacritty#7559.
Fixes alacritty#7533.

* Fix serde tests without default features

* Alacritty version 0.13.1-rc1

* Fix manpage string escapes

Co-authored-by: Christian Duerr <[email protected]>

* Alacritty version 0.13.1

* Reduce allocations during keyboard input

* Fix `debug.renderer="gles2pure"` documentation

Patch 5685ce8 changed the allowed values of the `debug.renderer` enum,
prohibiting the usage of `_` in the `Gles2Pure` variant. This patch
updates the documentation to correct for that.

Co-authored-by: Kirill Chibisov <[email protected]>

* Fix inline search expanding across newlines

Closes alacritty#7587.

* Fix env variable overrides through CLI

This fixes an issue where all CLI environment variables would replace
existing configuration file variables instead of merging the two maps
together.

Fixes alacritty#7618.

* Fix typo in config docs

Closes alacritty#7647.

* Allow specifying all config keys on all platforms

Closes alacritty#7592.

* Use builtin font to draw sextants

Sextants are similar to quadrants and should align with them and
other box drawing, thus use builtin font to align them properly.

Part-of: alacritty#7422.

* Fix invalid bounds in selection range conversion

* Don't report associated text only for C0/C1

This has a side effect that we'll have text reported for Alt+Shift+T
and similar, but only C0/C1 should be excluded and Alt+Shift+T is
emitting neither, thus regular `T` will be reported.

Fixes alacritty#7657.

* Move CHANGELOG entry for sextants to proper section

* Don't use kitty sequences outside protocol

Originally kitty defined that functional keys, which are not encoded
by default, like `Pause` should be encoded with `CSI u`. However
the specification was clarified and now it says that terminal
may ignore that part. Given that Alacritty tries to follow xterm/urxvt
when it comes to bindings, CSI u bindings are not send for consistency
reasons.

This also brings back F13-F20 bindings used by Alacritty in 0.12.3, as
well as explicitly defines `NumpadEnter` like it was before.

Closes alacritty#7623.

* Document `command` field in bindings

Closes alacritty#7594.

* Fix unnecessary explicit panic in PTY 

Closes alacritty#7680.

* Fix hang on startup with some Wayland compositors

Fixes alacritty#7665.

* Fix hang on startup with some Wayland compositors

Fixes alacritty#7665.

* Add default `Home`/`End` bindings for Vi mode

* Remove extra TIOCSWINSZ ioctl on startup

The openpty call already performs it, thus no need to call it one more
with the exact same size since it confuses some applications.

* Fix row indexing with inclusive ranges

* Use dynamic MSRV for oldstable CI

Instead of manually specifying the oldstable version in all our CI
scripts, it is now pulled from the `Cargo.toml` which simplifies the
update process.

The contributing guide has also been updated to not include the explicit
version and its wording has been loosened a bit to correctly represent
current maintenance practices.

* Bump MSRV to 1.72.0

* Fix clippy warnings

* Fix regional scrolling leaking into history

This fixes an issue where a scrolling region that does not start at the
top of the screen would still rotate lines into history when scrolling
the content "upwards".

* Fix typo in config docs

* Bump winit to 0.29.11

Fixes alacritty#7633.
Fixes alacritty#7613.
Fixes alacritty#7607.
Fixes alacritty#7571.
Fixes alacritty#7549.

* Fix feature = "cargo-clippy" deprecation

* Check alternative cursor icon names on Wayland

* Add alias support to `SerdeReplace`

* Bump winit to 0.29.12

The 0.29.11 was yanked.

* Fix build failure on NetBSD

x11-clipboard was unconditionally using eventfd which is not present
on NetBSD.

Links: quininer/x11-clipboard#48

* Fix log typos

* Bump winit to 0.29.14

Fixes alacritty#7806.

* Expose more process info on Windows

* Send exit code events on child process exit

Fixes alacritty#7753.

* Set PTY's pixel size on startup

117719b removed the extra call for TIOCSWINSZ, however the initial
`openpty` call itself did not set the pixel size, which caused issues
with some clients.

* Fix hint `Select` action for hyperlink escape

This fixes an issue where the `Select` action for hyperlink escape text
would select the entire line, instead of selecting only the hyperlink
itself.

It also changes the way hyperlinks with the same ID are highlighted,
removing the restriction of being on consecutive lines and instead
highlighting all visible cells that correspond to the matching
hyperlink.

Closes alacritty#7766.

* Bump winit to 0.29.15

* Bump dependencies

This bumps all dependencies that can be updated without introducing a
build failure.

* Drop MSRV to 1.70.0

* Allow setting terminal env vars via PTY options

Closes alacritty#7778.

* Alacritty version 0.13.2-rc1

* Fix kitty encoding used for char input without text

On Windows some key combinations for regular text input, like Ctrl+1
don't have any text attached, so they were generating the kitty escape
sequence even when they shouldn't.

* Fix msi installer build

This works around an issue where wix was pulling pre-release extensions
and thus breaking compatibility with our used wix version.

* Alacritty version 0.13.2

* Fix build

---------

Signed-off-by: Dennis Maier <[email protected]>
Signed-off-by: lilydjwg <[email protected]>
Co-authored-by: Kirill Chibisov <[email protected]>
Co-authored-by: Nathan Lilienthal <[email protected]>
Co-authored-by: Christian Duerr <[email protected]>
Co-authored-by: CRATO LABS <[email protected]>
Co-authored-by: K.B.Dharun Krishna <[email protected]>
Co-authored-by: Anhad Singh <[email protected]>
Co-authored-by: maierd <[email protected]>
Co-authored-by: Pavel Roskin <[email protected]>
Co-authored-by: Sonu Bardai <[email protected]>
Co-authored-by: Yug Shende <[email protected]>
Co-authored-by: Nick Reilingh <[email protected]>
Co-authored-by: Andrea Frigido <[email protected]>
Co-authored-by: Kirill Bulatov <[email protected]>
Co-authored-by: tv <[email protected]>
Co-authored-by: Max Brunsfeld <[email protected]>
Co-authored-by: Arhum Jain <[email protected]>
Co-authored-by: Rolf Sievert <[email protected]>
Co-authored-by: Simone Ragusa <[email protected]>
Co-authored-by: John Nunley <[email protected]>
Co-authored-by: Kyle Willmon <[email protected]>
Co-authored-by: Julian Braha <[email protected]>
Co-authored-by: Gregory Anders <[email protected]>
Co-authored-by: Cédric Van Rompay <[email protected]>
Co-authored-by: Hyper <[email protected]>
Co-authored-by: Philip Dubé <[email protected]>
Co-authored-by: Lars Francke <[email protected]>
Co-authored-by: Omar Magdy <[email protected]>
Co-authored-by: James McCoy <[email protected]>
Co-authored-by: WuerfelDev <[email protected]>
Co-authored-by: Popa Ioan Alexandru <[email protected]>
Co-authored-by: Mohammad AlSaleh <[email protected]>
Co-authored-by: Conrad Irwin <[email protected]>
Co-authored-by: Alexandru Placinta <[email protected]>
Co-authored-by: Yadi Abdalhalim <[email protected]>
Co-authored-by: Dimitris Apostolou <[email protected]>
Co-authored-by: Friz64 <[email protected]>
Co-authored-by: huajin tong <[email protected]>
Co-authored-by: Small White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.