-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event: Move event recording in ValidatingWebhook to controller #1844
Comments
Agreed. |
@devholic I'll leave it up to you whether this needs to be changed in the v0.6.0 timeline or if the current behavior is acceptable for now, making this lower priority. Your call. |
@krancour Focusing on event tracking itself has higher priority for v0.6.0, so I think we can do this after v0.6.0 is released. |
devholic
added a commit
that referenced
this issue
May 14, 2024
Part of #1844 Signed-off-by: Sunghoon Kang <[email protected]>
devholic
added a commit
that referenced
this issue
May 14, 2024
Fixes #1844 Signed-off-by: Sunghoon Kang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
As @hiddeco pointed out, recording Events on ValidatingWebhook doesn't guarantee that the given event is really happened or not because other ValidatingWebhook in cluster can affect the result of validation.
Proposal
Instead of recording events in ValidatingWebhook,
References
The text was updated successfully, but these errors were encountered: