Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different keyboard layouts #216

Open
albfan opened this issue Oct 13, 2019 · 5 comments
Open

Different keyboard layouts #216

albfan opened this issue Oct 13, 2019 · 5 comments

Comments

@albfan
Copy link
Collaborator

albfan commented Oct 13, 2019

Expected Behavior

Zoom in shortcut Ctrl+= is not standard and breaks the workflow in spanish.

Typical zoom shorcuts are:

  • Ctrl++: Zoom in
  • Ctrl+-: Zoom out
  • Ctrl+0: Reset zoom

I check other programs (tilix https://github.com/gnunn1/tilix/blob/master/data/gsettings/com.gexperts.Tilix.gschema.xml#L1191) and this is pretty standard.

In spanish Ctrl++ is a direct key press. To use Ctrl+=, we need to press Ctrl+Shift+0.

Seems in english is the opposite and Ctrl++ is not a direct keypress.

Current Behavior

Ctrl+= executes zoom in.

Possible Solution

  • Stick to standards.
  • Deal with this in a l10n way
  • Allow to customize shortcuts

Context

  • Akira Version: master
  • OS Info: Arch linux
@Alecaddd
Copy link
Member

Ah! That makes sense, that's why we were colliding on that.
I Think for now we can stick to standards and then allow shortcut customization, so we don't need to handle localization for keyboard shortcuts, which it could get pretty hairy.
Thanks for investigating this.

@albfan
Copy link
Collaborator Author

albfan commented Oct 14, 2019

Should we set to Ctrl + + then?

@Alecaddd
Copy link
Member

Yes, let's leave it like it is right now, after your update to master.
What do you think?

@albfan
Copy link
Collaborator Author

albfan commented Oct 14, 2019

I think right now is Ctrl + =.

Any idea about how zoom in and out should behave? I think zoom in is not intuitive right now ( but can find how to make it more natural) Looking at other apps may work, but any idea is appreciated.

@Alecaddd
Copy link
Member

Alecaddd commented Oct 14, 2019

You updated master here: https://github.com/akiraux/Akira/blob/master/src/Services/ActionManager.vala#L89
So it's plus, let's leave it like that for now.

For the zoom, I'm taking care of that in the canvas-action branch, I should have a PR ready for review tomorrow.
Here's the behaviour:

Zoom in: CTRL + Scroll Up
Zoom out: CTRL + Scroll down

Is this what were you asking? Sorry if I didn't understand your question 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants