fix resolves symlink on cd at zsh
#777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalton-oliveira
force-pushed
the
main
branch
3 times, most recently
from
bc45490
to
41c0e82
Compare
dalton-oliveira
force-pushed
the
main
branch
2 times, most recently
from
5f7493c
to
333d624
Compare
|
@ajeetdsouza thank you for this amazing tool! It has already saving me a lot of keystrokes. Hope this PR is adequate and thanks for taking a look. |
|
Tested this branch using @dalton-oliveira's instructions here and it seems to totally fix my issue in #740 😍 |
|
@dalton-oliveira just one question - why do we not use |
|
@ajeetdsouza I was concerned to break something that I couldn't check manually. Just removed the conditional |
|
Thanks for doing this @dalton-oliveira! ❤️ |
|
Just tested again since that last commit. Still works great / fixes my MacOS case sensitivity issues in #740 👍 Thoughts on this one @ajeetdsouza 🙏 |
|
I have a similar issue to @jesseleite - would love to see this merged! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having
_ZO_RESOLVE_SYMLINKSenv var defined as "1", makes zoxide to chase symink of directory before adding it to the database. This behavior can be more coherent if thecdcommand also does the same. That's specially useful for APFS which is case insensitive by default. Closes #740.What was done
Adds
CHASE_LINKSoption tocd, the same one used inpwdon zsh.