Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve speed of getTopUsers #147

Open
ajayyy opened this issue Sep 16, 2020 · 3 comments
Open

Improve speed of getTopUsers #147

ajayyy opened this issue Sep 16, 2020 · 3 comments

Comments

@ajayyy
Copy link
Owner

ajayyy commented Sep 16, 2020

This is using up a lot of CPU
@andrewzlee
Copy link
Contributor

You indexing on userID?

@MRuy
Copy link
Contributor

MRuy commented Oct 6, 2020 •
edited

Until we have redis implemented i would implement a simple X minute in-memory cache

MRuy added a commit to MRuy/SponsorBlockServer that referenced this issue Oct 6, 2020
@MRuy
Add cache for getTopUsers
25b91af 
See ajayyy#147
@MRuy MRuy mentioned this issue Oct 6, 2020
Merged
@Joe-Dowd
Copy link
Contributor

Joe-Dowd commented Oct 6, 2020

Redis is already implemented (at least in the code): https://github.com/ajayyy/SponsorBlockServer/blob/master/src/utils/youtubeAPI.js

It's just waiting for ajay to put it on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MRuy @Joe-Dowd @andrewzlee @ajayyy