Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck issues in airmon-ng #2516

Open
Mister-X- opened this issue Mar 13, 2023 · 5 comments
Open

Fix shellcheck issues in airmon-ng #2516

Mister-X- opened this issue Mar 13, 2023 · 5 comments
Assignees

Comments

@Mister-X-
Copy link
Collaborator

Description

There are still a few things to fix in airmon-ng, that were reported by shellcheck. They are ignored for the time being so that linting (#2501) won't fail.

This is just to keep track of them so they're not forgotten in the code. There are approximately 20 of them (Search for disable=).

@wileyhy
Copy link
Contributor

wileyhy commented Jul 28, 2023

One of these was fixed with #2551

@wileyhy
Copy link
Contributor

wileyhy commented Jul 30, 2023

Here's a current list as of today.

 $ grep -oEe 'disable=(SC)?[0-9]{4}' ./scripts/airmon-ng.linux | sort | uniq -c
      8 disable=2009
      1 disable=2012
      4 disable=2045
      2 disable=2059
      1 disable=2166
      2 disable=2181

@ZeroChaos-
Copy link
Collaborator

As noted in the comments, some of those are correct and NOT going to be removed due to compatibility requirements. Just grepping for disable is not providing an accurate list. Off the top of my head all the warnings about ps simply don't apply to us.

@wileyhy
Copy link
Contributor

wileyhy commented Jul 30, 2023

Okay. ...that's true, some systems still don't have pgrep yet

@ZeroChaos-
Copy link
Collaborator

It's mostly that isn't not default and I didn't want to force the install. The warning is right, ps is harder to use, but it does work :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants