Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill the cloudwatch_monitoring module #1241

Open
ryandeivert opened this issue Apr 30, 2020 · 0 comments
Open

kill the cloudwatch_monitoring module #1241

ryandeivert opened this issue Apr 30, 2020 · 0 comments

Comments

@ryandeivert
Copy link
Contributor

Background

The cloudwatch_monitoring module is absolute ๐Ÿ—‘๏ธ. Right now there is a janky dependency between the kinesis module and this one and it's easy to mess up. Also, the configuration for alarm settings is terrible and requires a user to properly set unwieldy strings like kinesis_iterator_age_error_evaluation_periods (??? whyy). Our lambda module already supports configuring alarms, with a pleasant way of configuring settings. The kinesis module should do the same, and the cloudwatch_monitoring module should die.

Desired Change

Deprecate the cloudwatch_monitoring module in favor of applying alarms within other modules directly. The source of the cloudwatch_monitoring module can be repurposed for this, but the module of cloudwatch_monitoring itself should never be explicitly used going forward.

@ryandeivert ryandeivert added this to the 3.3.0 milestone Apr 30, 2020
@ryandeivert ryandeivert modified the milestones: 3.3.0, 3.4.0 Aug 4, 2020
@ryandeivert ryandeivert modified the milestones: 3.4.0, 4.1.0 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant