Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry packaging #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Poetry packaging #835

wants to merge 1 commit into from

Conversation

dazza-codes
Copy link
Contributor

@dazza-codes dazza-codes commented Nov 3, 2020 •
edited

Fix #833 although it does not use a lambci docker container in the travis-CI matrix.

This PR is a response to difficulty on a couple of other PRs when I can't grapple with pipenv for my dev-env. There might be bits-n-pieces of this PR that are welcome and other bits that are not. I'm open to discussion, testing and compromises. I'm not having much success with pipenv. Even if this PR is not adopted/merged, I will find it useful to work with this branch and rebase on master and manage a parallel set of poetry-deps as needed.

This is an attempt to use poetry packaging for the project and it might be a contentious PR/issue, depending on dev-team preferences for dev-env setups. In using poetry for the past year or so, this PR represents some patterns that are working consistently for me. Hopefully the added files are mostly self-explanatory, please ask any questions to clarify things and take it for a spin on your local to see how it works out.

TODO

  • update CI/CD to use poetry
  • contributions require using python 3.8 now (?)
  • tests might assume there is a default profile available to get credentials (?), lots of failures without it

@dazza-codes dazza-codes mentioned this pull request Nov 3, 2020
Closed
@thehesiod
Copy link
Collaborator

hmm perhaps aioboto should switch to pyproject.toml as well. Sorry really behind in the forward looking PRs, will try to look soon just been super busy since move, or maybe another aioboto admin can chime in =)

@dazza-codes dazza-codes force-pushed the poetry-packaging branch 7 times, most recently from 3d034ac to e6ae3cc Compare November 5, 2020 05:09
@aio-libs aio-libs deleted a comment from CLAassistant Nov 21, 2020
@dazza-codes dazza-codes force-pushed the poetry-packaging branch 7 times, most recently from 26fd5c6 to 32bd40b Compare June 6, 2021 18:19
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2021

This pull request fixes 5 alerts when merging 32bd40b into 2a7c7f5 - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

@dazza-codes dazza-codes force-pushed the poetry-packaging branch 5 times, most recently from a3aea42 to 12d3d09 Compare June 6, 2021 19:15
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2021

This pull request fixes 5 alerts when merging 12d3d09 into 2a7c7f5 - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

@dazza-codes dazza-codes force-pushed the poetry-packaging branch 2 times, most recently from 4c15807 to b8e8436 Compare June 6, 2021 20:42
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2021

This pull request fixes 5 alerts when merging b8e8436 into 2a7c7f5 - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Aug 25, 2021

This pull request fixes 6 alerts when merging b1dc068 into ef96004 - view on LGTM.com

fixed alerts:

  • 3 for `__eq__` not overridden when adding attributes
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Missing call to `__init__` during object initialization

@dazza-codes dazza-codes force-pushed the poetry-packaging branch 2 times, most recently from c40597a to 7771889 Compare August 25, 2021 01:22
Use poetry to manage the project
ea83ed1 
- poetry manages all aspects of project
  metadata and dependencies in pyproject.toml
- Pipfile is obsolete
- setup.py is obsolete
- project might only support python >=3.7,<4.0 now?
  - tests will not run in python 3.6.x
  - contributions require python 3.8
@thehesiod
Copy link
Collaborator

@dazza-codes given that botocore has swapped to https://github.com/boto/botocore/blob/develop/pyproject.toml seems like this now makes even more sense, thoughts?

@lafrenierejm
Copy link
Contributor

lafrenierejm commented Oct 16, 2022 •
edited

@dazza-codes I rebased on this PR to fix unit tests and linting in my fork: lafrenierejm/aiobotocore@poetry-packaging. Would you consider resetting this PR to my updated branch? Or would you prefer that I open a separate PR for review?

@lafrenierejm lafrenierejm mentioned this pull request Oct 23, 2022
Open
13 tasks
@thehesiod
Copy link
Collaborator

could you work with #975 so we get a PR that includes both aspects? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use in AWS Lambda with minimal layer sizes
3 participants
@dazza-codes @thehesiod @lafrenierejm