Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLB-specific test case added #1274

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

AMLB-specific test case added #1274

wants to merge 18 commits into from

Conversation

nicl-nno
Copy link
Collaborator

Error "IndexError: arrays used as indices must be of integer (or boolean) type" is found if final pipeline contains "resample" op

Copy link

docu-mentor bot commented Mar 13, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link

👋 Hi, I'm @open-code-helper, an LLM-powered GitHub app
powered by NVIDIA AI Foundation Models and Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@open-code-helper run

and I will start my analysis. I only look at what you changed
in this PR.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (cd915a8) to head (c18a80f).
Report is 6 commits behind head on master.

❗ Current head c18a80f differs from pull request most recent head 773ff88. Consider uploading reports for the commit 773ff88 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   79.88%   79.95%   +0.07%     
==========================================
  Files         146      146              
  Lines       10065    10051      -14     
==========================================
- Hits         8040     8036       -4     
+ Misses       2025     2015      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Apr 1, 2024

Hello @nicl-nno! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-15 20:49:57 UTC

Copy link
Collaborator

@Lopa10ko Lopa10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не очень понимаю, как этот PR связан с #1273
исправления в get_metrics не должны были повлиять на IndexError в AMLB интеграционнике

по поводу AMLB-specific теста:
верно ли понимаю, что проблема пока регистрируется только на пайплайнах с нодой resample?
наверное, стоит преобразовать np.ndarray в InputData и с уже верными индексами (пусть даже idx=np.arange(len(x_train)) скормить пайплайну на resample.

test/unit/api/test_main_api.py Outdated Show resolved Hide resolved
test/integration/api/test_main_api.py Outdated Show resolved Hide resolved
test/integration/api/test_main_api.py Outdated Show resolved Hide resolved
fedot/api/main.py Outdated Show resolved Hide resolved

@pytest.mark.parametrize('initial_assumption, timeout',
[(resample_pipeline, 0.001),
(None, 5.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не очень понятна идея, для чего здесь implicit initial_assumption=None?
будет NoneType object is not subscriptable где-то при попытке логировать

@DRMPN
Copy link
Collaborator

DRMPN commented Apr 10, 2024

/fix-pep8

@DRMPN
Copy link
Collaborator

DRMPN commented Apr 11, 2024

✅ Integration run - https://github.com/aimclub/FEDOT/actions/runs/8644854445

DRMPN and others added 2 commits April 15, 2024 16:02
@DRMPN
Copy link
Collaborator

DRMPN commented Apr 15, 2024

/fix-pep8

@DRMPN
Copy link
Collaborator

DRMPN commented Apr 15, 2024

✅ Integration run - https://github.com/aimclub/FEDOT/actions/runs/8695868602

@nicl-nno nicl-nno closed this May 7, 2024
@nicl-nno nicl-nno reopened this May 7, 2024
Copy link

docu-mentor bot commented May 7, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid fitness after objective evaluation. Skipping the graph: (/n_scaling;)/n_rf_{'n_jobs':32}
4 participants