Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Suggestion: mention React Key in troubleshooting #162

Open
mprast opened this issue Aug 2, 2021 · 0 comments
Open

Doc Suggestion: mention React Key in troubleshooting #162

mprast opened this issue Aug 2, 2021 · 0 comments

Comments

@mprast
Copy link

mprast commented Aug 2, 2021

Hello! I just finished working on an animation that had on onExit() callback that wasn't working until I added a key prop to my Flipped element. I know key is a React thing and not a react-flip-toolkit thing, but this suggests to me there's something about the way react-flip-toolkit works with react that requires key to be there, some of the time or all of the time (especially since every example seems to use a key prop as well).

It may make sense to add a quick note to the docs advising users to try adding a key prop in case of trouble - I know it's generally best practice to do so, but React only gives a warning and not an error if it's missing, and it's a bit confusing to have things break when all of the library-specific config is correct!

(Love this library btw! It's so, so nice to be able to do complex animations declaratively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant