Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when there's no internet connection #69

Open
marvinjude opened this issue Apr 3, 2020 · 3 comments
Open

Better error message when there's no internet connection #69

marvinjude opened this issue Apr 3, 2020 · 3 comments

Comments

@marvinjude
Copy link

marvinjude commented Apr 3, 2020 •
edited

Nice work! @ahmadawais

The CLI displays "API is down" when data fetching fails, that's not so bad, but I think it feels better to let users know they're offline.

Something like this
Screen Shot 2020-04-03 at 1 00 56 PM
@marvinjude
Copy link
Author

I have a commit that fixes this, should I send in a PR?

@ahmadawais
Copy link
Owner

Sure thing send in a PR

@marvinjude marvinjude mentioned this issue Apr 4, 2020
Closed
@marvinjude
Copy link
Author

There you go 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmadawais @marvinjude