Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdownfy_view is unauthenticated - Please consider changing it #194

Open
vnagendra opened this issue Jan 18, 2023 · 1 comment · May be fixed by #195
Open

markdownfy_view is unauthenticated - Please consider changing it #194

vnagendra opened this issue Jan 18, 2023 · 1 comment · May be fixed by #195

Comments

@vnagendra
Copy link

Currently the installation document/README just says add URLs to your Django. No issues with this part. What is not specified here is that the URL /martor/markdownify/ now becomes "public". By itself, it is not a problem. There maybe many "mitigating" circumstances such as ALBs that don't allow /martor/ URLs and such. But, if someone were to just directly deploy this without reading the code, they have unintentionally exposed an unauthenticated URL.

Either we should call it out explicitly in the README, or better yet, there should be no reason for the function markdownfy_view to not have the login_required decorator which all the other functions have.
@vnagendra vnagendra linked a pull request Jan 18, 2023 that will close this issue
Open
@agusmakmun
Copy link
Owner

Answered here: #195 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Authenticated markdownfy_view termtegrity/django-markdown-editor
2 participants
@vnagendra @agusmakmun