Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard mapping config not persisted over restart? #440

Closed
8 tasks
complyue opened this issue May 3, 2024 · 2 comments
Closed
8 tasks

Keyboard mapping config not persisted over restart? #440

complyue opened this issue May 3, 2024 · 2 comments

Comments

@complyue
Copy link
Contributor

complyue commented May 3, 2024

Describe the bug

I changed P1's keyboard key mappings to ASD and played fine. But once the game is restarted, the key mapping is reverted to arrow keys.

How to reproduce

  1. start the game
  2. change keyboard mapping to other than default
  3. restart the game
  4. the key mappings are reverted to default

Expected behavior

Key mappings should persist over restarts of the game

Information about your build

Pixel Wheels version:

master branch @ 2.5.1

Binary origin:

OS:

  • Android
  • Windows
  • macOS
  • [x ] Linux

OS version:

Optional information

I'd like to contribute a PR for a fix, but no idea where to start looking.

Additional context

N/A

@agateau
Copy link
Owner

agateau commented May 22, 2024

Hi,

This is odd: I can't reproduce it. Some more details about this:

  • Key bindings are saved to disk by GameConfig.savePlayerInputHandlerConfig()
  • They are stored in ~/.config/pixelwheels/pixelwheels.conf
  • They are loaded from disk by GameConfig.setupInputHandlers() (which is a bit convoluted...)

@complyue
Copy link
Contributor Author

Really odd, it works for me this time, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants