Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React19beta and 'ResizeObserver': parameter 1 is not of type 'Element' #7948

Closed
rbox-risk opened this issue May 11, 2024 · 1 comment
Closed
Labels

Comments

@rbox-risk
Copy link

I'm submitting a ...

[x] bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'

Providing a Reproducible Scenario
Accepted reproducible scenarios are

  • A description of the detailed steps to reproduce your behaviour in one of our examples in the docs.
  • A plunker

In preparation for React19, as per most recent announcement from React, app developers should use [email protected]
https://react.dev/blog/2024/04/25/react-19-upgrade-guide
while feedback is obtained from library maintainers on [email protected]

While testing on next.js,
[email protected] became a peer dependency from 14.3.0-canary.45 and onwards.

at which point the ResizeObserver bug appears in ag-grid.
Reproduction below using most recent next@canary

https://codesandbox.io/p/github/rbox-risk/agv2-react19beta/main?import=true

To see the code working simply pnpm add [email protected]

While not technically a bug for current non-beta releases, this may become a bug upon the release of react@19

Current behavior
Any use of AG-grid exits with fatal error:
TypeError: Failed to execute 'observe' on 'ResizeObserver': parameter 1 is not of type 'Element'.

(A similar situation for ResizeObserver happened during the pre-release of React18)

Expected behavior
No fatal error

Please tell us about your environment:
React

  • AG Grid version: X.X.X
    31.3.1

  • Browser:
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    ES6/7

@AG-Zoheil
Copy link

Hello

Thank you for reporting this - much appreciated!

Based on your description we've now reproduced this issue as a bug.

We have added this bug to our backlog and we are tracking it with the following reference: AG-11651

We try to fix bugs from one release to the next, so this should be fixed in the next release or the one after if it was raised too close to the next release date.

See whether this item will be in the next release by checking the NEXT RELEASE checkbox on the product pipeline page:
https://www.ag-grid.com/ag-grid-pipeline/

The best way to track this is to sign up for AG Grid new release notifications using the instructions here. This way you'll know as soon as a new version is out and you can check whether this specific item was implemented on the changelog page.

Thanks again for bringing this up with us.

Kind regards,
Zoheil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants