Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filter rendered over table when setFilterModel is set on startup #7926

Closed
holomekc opened this issue May 6, 2024 · 7 comments
Closed
Labels

Comments

@holomekc
Copy link

holomekc commented May 6, 2024

I'm submitting a ...

[x] bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'

Current behavior
When using setFilterModel() to set an initial filter on startup the custom filter component is rendered over the table at the bottom:
image
image

A click on the filter button in the table header fixes the issue and the filter behaves as usual, but on the next page reload the issue appears again.

Expected behavior
As in earlier versions the filter is not rendered over the table.

Please tell us about your environment:
Mac OSX Sonoma 14.4.1
IDE IntelliJ
Angular 17.3.7

  • AG Grid version: X.X.X
    31.3.1

  • Browser:
    Chrome

  • Language: [TypeScript 5.4.5]

@sergioorlov
Copy link

I've the same problem...

@holomekc
Copy link
Author

holomekc commented May 7, 2024

Hi @sergioorlov
My ugly workaround is to adjust the custom filter with a property called hidden, which is initially set to true and is hiding the filter (display: none) and then set the value to false in the onOpened() hook. It is super ugly, but maybe helps until the issue is fixed.

@sergioorlov
Copy link

Hi @sergioorlov My ugly workaround is to adjust the custom filter with a property called hidden, which is initially set to true and is hiding the filter (display: none) and then set the value to false in the onOpened() hook. It is super ugly, but maybe helps until the issue is fixed.

Thanks for your hack, but I'll return previous version for now and awaiting when ag-grid developers fix this problem )

@Kramy
Copy link

Kramy commented May 7, 2024

I found a similar case when we add a custom column filter to a grouped column that also has a column filter.

I've created a reproducible scenario here.

@sergioorlov
Copy link

@AG-Zoheil when will be fix it ?

@dotlens
Copy link

dotlens commented May 16, 2024

Can be reproduces with the custom filter example: https://www.ag-grid.com/examples/component-filter/filter-component/modules/angular/

Just click the Button "Invoke Filter Instance Method" in the top bar, and the custom filter will apear at the bottom of the grid.

@AG-Zoheil
Copy link

Hello

Thank you for reporting this - much appreciated!

Based on your description we've now reproduced this issue as a bug.

We have added this bug to our backlog and we are tracking it with the following reference: AG-11633

We try to fix bugs from one release to the next, so this should be fixed in the next release or the one after if it was raised too close to the next release date.

See whether this item will be in the next release by checking the NEXT RELEASE checkbox on the product pipeline page:
https://www.ag-grid.com/ag-grid-pipeline/

The best way to track this is to sign up for AG Grid new release notifications using the instructions here. This way you'll know as soon as a new version is out and you can check whether this specific item was implemented on the changelog page.

Thanks again for bringing this up with us.

Kind regards,
Zoheil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants