Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Chapters not sorted when embedded in audio file in incorrect order #3007

Closed
advplyr opened this issue May 24, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@advplyr
Copy link
Owner

advplyr commented May 24, 2024

What happened?

Scanned in a single file m4b audiobook with embedded chapters. The embedded chapters have an id in ascending order but the start timestamps are not.
When using embedded chapters Abs is sorting by id instead of start causing the chapters to be in an incorrect order.

What did you expect to happen?

Sort by chapter start

Steps to reproduce the issue

  1. Audio file with embedded chapters where the start times are not ascending
  2. Scan audiobook & review chapters

Audiobookshelf version

v2.9.0

How are you running audiobookshelf?

Docker

What OS is your Audiobookshelf server hosted from?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

None

Logs

{
      "id": 97,
      "time_base": "1/1000",
      "start": 34725255,
      "start_time": "34725.255000",
      "end": 35026107,
      "end_time": "35026.107000",
      "tags": {
        "title": "Chapter 98"
      }
    },
    {
      "id": 98,
      "time_base": "1/1000",
      "start": 35026107,
      "start_time": "35026.107000",
      "end": 35401434,
      "end_time": "35401.434000",
      "tags": {
        "title": "Chapter 99"
      }
    },
    {
      "id": 99,
      "time_base": "1/1000",
      "start": 0,
      "start_time": "0.000000",
      "end": 7862,
      "end_time": "7.862000",
      "tags": {
        "title": "Introduction"
      }

Additional Notes

image

@advplyr advplyr added the bug Something isn't working label May 24, 2024
advplyr added a commit that referenced this issue May 24, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label May 24, 2024
nichwall pushed a commit to nichwall/audiobookshelf that referenced this issue May 25, 2024
@advplyr
Copy link
Owner Author

advplyr commented May 27, 2024

Fixed in v2.10.0

@advplyr advplyr closed this as completed May 27, 2024
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant