Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize request error handling process #572

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

xyq-c-cpp
Copy link
Collaborator

@xyq-c-cpp xyq-c-cpp commented Jun 20, 2024

In some cases, the REST API will return a response with the body:

{"error": "Internal error: 1"}

When this happens, it returns an ApiError that shows nothing meaningful when the user calls the REST API interface. Optimize the request error handling process to make the error more meaningful.

v2/client.go Outdated Show resolved Hide resolved
@adshao
Copy link
Owner

adshao commented Jun 20, 2024

Hi @xyq-c-cpp , please check the review comment.

@xyq-c-cpp
Copy link
Collaborator Author

Hi @xyq-c-cpp , please check the review comment.

hi, see the response for the review comment.

@adshao adshao merged commit 1ba84a6 into adshao:master Jun 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants