changed bool types to string in reduceOnly, closePosition, priceProtect. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adshao please check🙂 |
|
Hi @size12 , could you please add unit tests for this change? |
|
This fix works in my project. Before this fix, I always got error when using BatchOrder [ code=-1102, msg=Mandatory parameter 'reduceOnly' was not sent, was empty/null, or malformed. code=-1102, msg=Mandatory parameter 'reduceOnly' was not sent, was empty/null, or malformed.]} |
|
@adshao hi, this problem still exists, so please review my PR :) |
adshao
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are should be STRING types in this fields.
BOOL type is still working in single order requests, but not is batch ones.