-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ws order vs order consistency #341
Comments
great, my opinion is same as yours. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I could have two suggestion, it would be:
Here you have two things that come from different places (REST and WS). Nevertheless, they do the same thing, yet they differ in fields that could be the same.
*
binance.WsOrderUpdate
and *binance.Order
have same fields, but... order side is oncestring
, oncebinance.SideType
. The same goes forstatus
, and such things... There are also fields that have same purpose, but different naming. It is also not helpful if naming is somewhat different from original binance, introducing even more mess into cryptic terminology, and guessing what would be the difference between "volume", "quantity" and all its variants. :)(edit: also ClientOrderId vs ClientOrderID)...
The text was updated successfully, but these errors were encountered: