Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws order vs order consistency #341

Closed
ljubomirb opened this issue Jan 25, 2022 · 1 comment
Closed

ws order vs order consistency #341

ljubomirb opened this issue Jan 25, 2022 · 1 comment

Comments

@ljubomirb
Copy link

ljubomirb commented Jan 25, 2022

If I could have two suggestion, it would be:

  • if naming could be more in tune with binance naming (that is for sure cryptic itself to non trader, but nevertheless, one needs to look at there because it is somewhat better documented)
  • and also - if everything can be somewhat more "standardized". Like, for example - "orders"
    Here you have two things that come from different places (REST and WS). Nevertheless, they do the same thing, yet they differ in fields that could be the same.
    *binance.WsOrderUpdate and *binance.Order have same fields, but... order side is once string, once binance.SideType. The same goes for status, and such things... There are also fields that have same purpose, but different naming. It is also not helpful if naming is somewhat different from original binance, introducing even more mess into cryptic terminology, and guessing what would be the difference between "volume", "quantity" and all its variants. :)

(edit: also ClientOrderId vs ClientOrderID)...

@ljubomirb ljubomirb changed the title ws order vs order consitency ws order vs order consistency Jan 25, 2022
@xyq-c-cpp
Copy link
Collaborator

great, my opinion is same as yours. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants