Apply requestgen to the requests

[c9s]

Hello @adshao,

I found you're using the cascading pattern for the request call for the whole binance library, I think you might be interested in this.

https://github.com/c9s/requestgen

I also like your cascading pattern calls for the binance API, so I wrote a tool to generate the accessor methods from the struct, this way you can generate the requests very easy.

This tool is used in bbgo (https://github.com/c9s/bbgo), and we're also using your go-binance package.

[adshao]

Hi @c9s , requestgen is so cool, actually the plan of go-binance v3 is also to use generation tool to automatically generate most of the SDK code. I think v3 can reuse your work.

[c9s]

That's great! Looking forward to hearing the feedback from you :)

[c9s]

FYI, Just added more features in requestgen https://github.com/c9s/requestgen

[c9s]

@adshao I can send a pull request for integrating this if you want.

[adshao]

@adshao I can send a pull request for integrating this if you want.

It's great, we can discuss the pr, will you break the compatibility? If yes, we should move it to v3.

[adshao]

@c9s could you describe the work you will do?

[c9s]

I would like to make it backward compatible

But I need to have a PoC first, and see if we can do it in v2, what do you think?

[adshao]

We can do it in v2 as long as it's backward compatible

[c9s]

I implemented my own binance http api client with requestgen, you may take a look:
https://github.com/c9s/bbgo/pull/575/files

[c9s]

or maybe you can also simply use my code :D

[c9s]

@adshao I wrote a tutorial about the requestgen for the binance api.

https://github.com/c9s/requestgen-tutorial

[xyq-c-cpp]

No response for a long time, close this issue