Websocket timeout

[ghost]

Hi adshao, first of all thanks for your work. Really appreaciated. I just wanted to ask you if there's a connection timeout or ping/pong mechanism to ensure connection stability?

[adshao]

hi @davidklodner , thanks for the issue.
for connection timeout, do you mean readdealine as in https://godoc.org/github.com/gorilla/websocket#Conn.SetReadDeadline , I think we can add it as a websocket config; while for ping/pong handler, I cannot find any info about it from binance api doc, and I tested it with https://godoc.org/github.com/gorilla/websocket#Conn.SetPingHandler and https://godoc.org/github.com/gorilla/websocket#Conn.SetPongHandler, there is nothing sent from binance server, I think it's fine to ignore them.
Do you have any better suggestion?

[ghost]

@adshao Try setting a pong handler and sending the server a ping. If the server correctly implements the websocket protocol, then the application should receive a pong. This may not be documented because it's at the Websocket protocol level, not part of the application.

[adshao]

@claudia-jones thanks for the update, you are right, we can periodically send ping message to server, and check pong message for connection stability.

[kustov-an]

Hi! Any updates on this?

[adshao]

hi @kustov-an , will implement it soon.

[adshao]

I don't think we need ping/pong handler here, instead, HandshakeTimeout https://godoc.org/github.com/gorilla/websocket#Dialer and CloseHandler https://godoc.org/github.com/gorilla/websocket#Conn.SetCloseHandler are enough to check connection stability.
Since these changes will break the compatibility, we need to refactor the web socket interfaces.

[kustov-an]

Correct me if I wrong, but as I understand

1. HandshakeTimeout is only used when establishing a new connection
2. CloseHandler is executed when the connection is closed by the peer
   So those changes are not going to help when the connection is lost due to network problems?

[adshao]

hi @kustov-an , if the connection is lost, ReadMessage will return error: https://github.com/adshao/go-binance/blob/master/websocket.go#L45, so we can use errHandler here.

[kustov-an]

Hi @adshao, please take a look at my pull request #50 addressing this issue

[adshao]

close as solved

[aleibovici]

@adshao your project has been a tremendous help. Much appreciated. I recently started seeing many "websocket: close 1008 (policy violation): Pong timeout" messages. I see that this case is closed, but I wonder if this is something you or anyone else is seeing. My code simply restart the a Websocket, but I wonder if I should be doing something diferent.

[snawaz]

@adshao your project has been a tremendous help. Much appreciated. I recently started seeing many "websocket: close 1008 (policy violation): Pong timeout" messages. I see that this case is closed, but I wonder if this is something you or anyone else is seeing. My code simply restart the a Websocket, but I wonder if I should be doing something diferent.

this is because #50 does not fix the problem, as it sends ping message whereas the client needs to send pong message. As the per the binance docs, it's the server which sends ping to the client and then if the client does not respond with a pong message within 10 mins, then the server will disconnect the connection.

[goriunov]

For future readers, as per @snawaz looks like if you set custom ping handler it will not automatically send pong based on the Gorilla websocket implementation. You will need to send pong back by yourself from within your custom ping handler.

This primarily required for the implementation on the gorilla websocket with custom handler. Note that if no handler is passed or no SetPingHandler called, it will default to the default ping handler

[snawaz]

For future readers, as per @snawaz looks like if you set custom ping handler it will not automatically send pong based on the Gorilla websocket implementation. You will need to send pong back by yourself from within your custom ping handler.

That's correct. I have a custom ping handler which sends websocket.PongMessage, as soon as it receives the PingMessage.