Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trade_service missing from delivery APIs #280

Closed
shanewright opened this issue Jul 7, 2021 · 1 comment
Closed

trade_service missing from delivery APIs #280

shanewright opened this issue Jul 7, 2021 · 1 comment

Comments

@shanewright
Copy link

Hi

Support for recent/historic/aggregated trades is present for the futures package, but not for the delivery (COIN-M) package, the Binance APIs are almost identical..
https://binance-docs.github.io/apidocs/futures/en/#recent-trades-list
https://binance-docs.github.io/apidocs/delivery/en/#recent-trades-list

The relevant code/API is present here for futures:
https://github.com/adshao/go-binance/blob/master/v2/futures/trade_service.go

...but not in the delivery package.

Is this an accidental omission or there is a technical reason? I can put together a patch/PR if that would be helpful?

@xyq-c-cpp
Copy link
Collaborator

No response for a long time, close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants