-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quoted-strings - support JSON encoded data in single quotes #668
Comments
What would the logic for this have to look like to be reliable? Suppose alb.ingress.kubernetes.io/actions.ssl-redirect: "{\"Type\": \"redirect\", \"RedirectConfig\": { \"Protocol\": \"HTTPS\", \"Port\": \"443\", \"StatusCode\": \"HTTP_301\"}}"
Another workaround is to make it a multiline scalar. alb.ingress.kubernetes.io/actions.ssl-redirect: >-
{"Type": "redirect", "RedirectConfig": { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}} I would personally style it with the JSON pretty-printed. alb.ingress.kubernetes.io/actions.ssl-redirect: >-
{
"Type": "redirect",
"RedirectConfig": {
"Protocol": "HTTPS",
"Port": "443",
"StatusCode": "HTTP_301"
}
}
|
Thanks @andrewimeson, I think your suggestion with JSON pretty-printed works just fine. |
For some Kubernetes manifests there are annotation with values in JSON format which have to be quoted in single quotes.
One example is AWS Load balancer Controller: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/ingress/annotations/
Linting this fails:
with error:
Would be possible to add support for this case instead of settigng
quote-type: any
(by default we usedouble
)?The text was updated successfully, but these errors were encountered: