-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nested sortable-group items. #359
Comments
For the 1st scenario, I believe you can solve the problem by adding explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've run into a few issues when using
ember-sortable
with nested groups. My original approach assumed a childsortable-group
onChange
handler would be responsible for sorting child items. Unfortunately, it seems these change events bubble up to the handler for parent items. Once I realized that to be the case, I was able to work around the issue, by filtering out items accordingly by inspecting the draggedItem argument in the parentonChange
callback. Would it be possible to scope change handlers to only worry about changes to directsortable-item
children? I believe this would make working with nested draggable lists a bit easier.The second challenge I've run into is that the transitionY transform applied to items during drag seems to break down with nested
sortable-group
s. Despite explicitly settingspacing
to 0 (though it seems this isn't required), a great deal of whitespace is inserted between all the draggable items in the tree (parent and child items). This makes for an unusable D&D experience, as it is difficult to drag an item past all the extra whitespace and still know where the item is going to be inserted relative to where it was previously.Original Approach
Screenshots
In this example, each category (i.e. Cherry, Apple, Peach) should be draggable to allow sorting of categories. In addition, each item within a category should also be draggable to allow sorting of those items (i.e. Cherry, Cherry With Fruit).
The text was updated successfully, but these errors were encountered: