Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting "display:none" on ListView parent crashes the page #6298

Open
bmingles opened this issue Apr 30, 2024 · 0 comments · May be fixed by #6357
Open

Setting "display:none" on ListView parent crashes the page #6298

bmingles opened this issue Apr 30, 2024 · 0 comments · May be fixed by #6357

Comments

@bmingles
Copy link

bmingles commented Apr 30, 2024

Provide a general summary of the issue here

If I set "display:none" on a parent element of a ListView, it crashes the page.

<div style={{ display: "none" }}>
    <ListView items={items}>
        {(item) => <Item key={item.id}>{item.name}</Item>}
    </ListView>
</div>

Possibly related to #6181

🤔 Expected Behavior?

ListView should not throw errors if parent is hidden.

😯 Current Behavior

ListView throws errors when parent is hidden.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/list-view-zero-height-forked-jr8h3h

Version

^3.34.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

MacOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✏️ To Groom
Development

Successfully merging a pull request may close this issue.

2 participants