Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests #156

Open
NateBaldwinDesign opened this issue May 4, 2022 · 0 comments
Open

Failing tests #156

NateBaldwinDesign opened this issue May 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@NateBaldwinDesign
Copy link
Collaborator

Description

Failing tests require more investigation as to why they are failing.

themeSetters.test: 'should set contrast multiple times'

This test should return gray100 value as "#ffffff". The value is defined as having 1:1 contrast with background color of "#ffffff". Regardless of any alterations to contrast for the theme, the returned color should equal the background color value. Test currently returns "#fefefe".

theme.test: 'should generate 2 colors with bidirectional contrast (dark background)'

This test should return a color value meeting (or exceeding) 4.5:1 contrast with background. Expected value to return would be "#9895c0" compared against background of "#323232". Test currently returns value "#9894c0", which is 4.48:1 contrast.

One consideration is to see if there were updates regarding the threshold value for inverting ratios or searchColor function. Ie, if they target an HSLuv value of 50% vs JCH value of 50% (different values), or if the actual percent is different (50% vs 49% or < x vs <= x);

Steps to reproduce

Expected behavior

  1. Expect colors that are 1:1 of same hue/sat to be the same color as background
  2. Expect colors with target ratio 4.5:1 to return 4.5:1 or greater

Screenshots

Leonardo package and version

Environment

  • Browser(s) and OS(s):

Additional context

@NateBaldwinDesign NateBaldwinDesign added the bug Something isn't working label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant