-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing tests #156
Labels
bug
Something isn't working
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Failing tests require more investigation as to why they are failing.
themeSetters.test
: 'should set contrast multiple times'This test should return gray100 value as "#ffffff". The value is defined as having 1:1 contrast with background color of "#ffffff". Regardless of any alterations to contrast for the theme, the returned color should equal the background color value. Test currently returns "#fefefe".
theme.test
: 'should generate 2 colors with bidirectional contrast (dark background)'This test should return a color value meeting (or exceeding) 4.5:1 contrast with background. Expected value to return would be "#9895c0" compared against background of "#323232". Test currently returns value "#9894c0", which is 4.48:1 contrast.
One consideration is to see if there were updates regarding the threshold value for inverting ratios or searchColor function. Ie, if they target an HSLuv value of 50% vs JCH value of 50% (different values), or if the actual percent is different (50% vs 49% or < x vs <= x);
Steps to reproduce
cd packages/contrast-colors
)yarn test
Expected behavior
Screenshots
Leonardo package and version
Environment
Additional context
The text was updated successfully, but these errors were encountered: