Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several warnings appear when installing the latest version of critical #585

Open
JacobDB opened this issue Jan 9, 2024 · 3 comments
Open

Comments

@JacobDB
Copy link

JacobDB commented Jan 9, 2024

I've been working on updating my gulpfile, and I'm getting a bunch of warnings on npm i. Here's what I've tracked down to critical:

  • critical: WARN  deprecated [email protected]: < 18.1.0 is no longer supported
  • critical -> inline-critical -> jsdom: WARN  deprecated [email protected]: Use your platform's native DOMException instead
  • critical -> inline-critical -> jsdom -> data-urls: WARN  deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
  • critical -> inline-critical -> jsdom: WARN  deprecated [email protected]: Use your platform's native atob() and btoa() methods instead

Any chance we can get this stuff updated?

@bezoerb
Copy link
Collaborator

bezoerb commented Jan 21, 2024

Hey @JacobDB, thanks for the issue.
Regarding the puppeteer dependency there's not much we can do about it. There's already an open PR on penthouse for this. As soon as puppeteer is updated upstream we can update our dependency as well: pocketjoso/penthouse#347

@JacobDB
Copy link
Author

JacobDB commented Jan 21, 2024

Gotcha, makes sense, I'll track that issue 🙂

@bezoerb
Copy link
Collaborator

bezoerb commented Jan 27, 2024

the ones from inline critical are resolved in v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants