-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testset in TripletMNIST and SiameseMNIST are not fixed #27
Comments
Thanks @luuyin, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great work! Thanks for sharing such elegant codes.
I have a small question, in TripletMNIST(Dataset) class. your annotation about testsets is "Test: Creates fixed triplets for testing"
However, in the code it is
triplets = [[i,
random_state.choice(self.label_to_indices[self.test_labels[i].item()]),
random_state.choice(self.label_to_indices[
np.random.choice(
list(self.labels_set - set([self.test_labels[i].item()]))
)
])
]
I think it maybe should be the followings:
I means use random_state.choice instead of np.random.choice of the original code, in order to create fixed testsets.
I am not sure If I am right, can we discuss it?
The text was updated successfully, but these errors were encountered: