[Bug]: RangeError: Maximum call stack size exceeded. when openning the application

[lelemm]

Verified issue does not already exist?

• I have searched and found no existing issue

Is this related to GoCardless, Simplefin or another bank-sync provider?

• I have checked my server logs and could not see any errors there
• I will be attaching my server logs to this issue
• I will be attaching my client-side (browser) logs to this issue
• I understand that this issue will be automatically closed if insufficient information is provided

What happened?

Imported some OFX with no problems, then I imported an CSV, categorized its transactions. Tried to go to budget, this error starts happening. Now I'm unable to open the application at all.

What error did you receive?

graph-data-structure.ts:79 Uncaught (in promise) RangeError: Maximum call stack size exceeded
at ep (graph-data-structure.ts:79:13)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)
at ep (graph-data-structure.ts:85:9)

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Operating System

Windows 11

[lelemm]

Linking to closed issue due missing information: #2241

[lelemm]

https://github.com/actualbudget/actual/files/14165218/crash.csv

[MatissJanis]

Ok, so it took me quite a while to get to the bottom of this. The crux of the problem is - transactions created WAYYYY in the past cause issues with budget table calculations. The simple fix for you would be - don't import transactions from 1980. Use the last few years.

To proper patch this we need to refactor topological sorting from a recursive implementation to an iterative one.

actual/packages/loot-core/src/server/spreadsheet/graph-data-structure.ts

Lines 79 to 92 in c82a6dc

	function topologicalSortUntil(name, visited, sorted) {
	visited.add(name);
	const iter = adjacent(name).values();
	let cur = iter.next();
	while (!cur.done) {
	if (!visited.has(cur.value)) {
	topologicalSortUntil(cur.value, visited, sorted);
	}
	cur = iter.next();
	}
	sorted.unshift(name);
	}

[lelemm]

Yeah, I imagined the problem was that.
A suggestion is to set a limit to the past where is "old enough" to actual keeps working.
In other words, if the user sets a date to much in the past, don't save it.

It's better to have this kind of lock cuz I see this as critical bug. The file is exported from the bank that way. If you don't pay enough attention when doing it, you just lose your instance or have to edit the database file by hand.

[lelemm]

Out of curiosity, I tried to see how far back we have to go to break the current code:
Considering today 19-03-2024, I had to put 19-03-2028 to have the same error, that's 96 years to the past. So, if you check if the transaction is more than 90 years old, we are safe.

This creates a interesting bug (hardly able to see by us): If I starting using actual today, it will fail to load at 19/03/2120. lol

[lelemm]

This would be the workaround I was thinking about.

I didn't try to run this code, I just forked and tried pinpoint where should be the change I suggested.

Since actual has syncing features for offline use, I can imagine there is a better/another place to make the same change.