New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actix-web doesn't compile with rustls 0.23.1 #3309
Comments
bind_rustls_022 only works with rustls 0.22 Mixing and matching multiple versions of the same library generally isn't supported When rustls 0.23 support is added, it will likely be through a new feature and bind call like bind_rustls_023 |
This error seems to also happen with rustls 0.22 with the aws-lc-rs feature enabled. |
Yea the rustls story is getting more complicated with the additional backends they're adding; not quite sure how to support them nicely yet. |
Expected Behavior
Update the dependencies for
actix-web-4.5.1
to userustls-0.23.1
and have it compile successfullyCurrent Behavior
After updating the dependencies for
actix-web-4.5.1
to userustls-0.23.1
, it fails with the following error:Possible Solution
When
rustls
moved to 0.23.0, it introduced a dependency onaws-lc-rs
which is its new default cryptography provider.However, there seems to be some compiler confusion where rust can't tell whether or not the tuple
Ok((path, guards, service))
in both theapp_service.rs
&scope.rs
is casted to a struct from theserder_json
crate or theaws-lc-rs
crate.My rust is very entry-level, but I'm hoping the fix can be as straightforward as adding an explicit cast to allow the compile to work as expected
Steps to Reproduce (for bugs)
actix-web
's Cargo.toml file0.22
to0.23.1
cargo test
Context
I'm trying to set-up an HTTPS server that is FIPS compliant. I was hoping to use the
bind_rusttls_022
function to use the latestrustls
version, which is FIPS certified via theaws-lc-rs
libraryYour Environment
rustc -V
): rustc 1.76.0 (07dca489a 2024-02-04)The text was updated successfully, but these errors were encountered: