New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to be able to test the route tree using match_pattern
and match_name
.
#3286
Comments
Hey, how about adding a clippy warning to catch and warn in cases like this. I assume the real pain happens if the developer doesn't realize some path is unreachable due to a match all pattern matched before the target path. |
Yeah giving a warning about unreachable routes sounds good to me. And yeah exactly this-
|
So currently the test requests does not seem to implement the match functions -
match_pattern
/match_name
.Consider the below app having two services:
And a test like this:
Expected Behavior
match_pattern
should print the matching route url/path, in this case: "/hello/{name}"match_name
should print the given name to the service, in this case: "greet"Current Behavior
Both
match_pattern
andmatch_name
returns None.Context
We can use these functions to test if the user has registered the services in the correct order as he/she intended and the user requests are in fact routing to correct handlers.
Currently, if user had registered the
greet
service beforegreet_me
service and a user sends the request to/hello/me
it will send"Hello me!`` whereas it should have returned
"Hi Developer!".That's what we wanted to test, Additional Context: qdrant/qdrant#3547.
Your Environment
The text was updated successfully, but these errors were encountered: