Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support add connection header thought header apis #3221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support add connection header thought header apis #3221

wants to merge 1 commit into from

Conversation

jonatansalemes
Copy link

resolves #3220

@kvzn
Copy link

kvzn commented Jan 16, 2024 •
edited

@fafhrd91 When can this be merged pls?

@fafhrd91
Copy link
Member

@fafhrd91 When can this be merged pls?

i dont have any affiliation with actix project anymore

@jonatansalemes
Copy link
Author

any updates ?

@jonatansalemes
Copy link
Author

thanks for running the pipeline, waiting for someone to review it

@jonatansalemes
Copy link
Author

jonatansalemes commented Apr 13, 2024 •
edited

someone to review it ? @robjtede

@jonatansalemes jonatansalemes mentioned this pull request Apr 17, 2024
Open
@jonatansalemes
Copy link
Author

still waiting for some review. @robjtede how can we move forward with this PR? Seems to have many issues correlated.

asonix
asonix reviewed May 19, 2024
View reviewed changes
actix-http/src/h1/encoder.rs Outdated Show resolved Hide resolved
actix-http/src/h1/encoder.rs Outdated Show resolved Hide resolved
@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch 3 times, most recently from f34dd1a to e65c649 Compare May 19, 2024 21:19
@jonatansalemes
Copy link
Author

@asonix thanks for your review, can you review it again?

asonix
asonix approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@asonix asonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind these changes. There's still the intermediate allocation of the AHashMap but it's probably small (number of headers in a request doesn't exceed 10 in most scenarios probably)

I think Rob still needs to look at this even if I approve it so 🤷

@jonatansalemes jonatansalemes force-pushed the feat/issue-3220-connection-header-precedence branch from e65c649 to 1295ed5 Compare May 20, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asonix asonix asonix approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending multipart request with angular rxjs
4 participants
@jonatansalemes @kvzn @fafhrd91 @asonix