Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow unpack msi if some cab are missing #175

Open
marakew opened this issue May 29, 2022 · 3 comments
Open

allow unpack msi if some cab are missing #175

marakew opened this issue May 29, 2022 · 3 comments

Comments

@marakew
Copy link

marakew commented May 29, 2022

--- a/src/LessMsi.Core/Msi/Wixtracts.cs
+++ b/src/LessMsi.Core/Msi/Wixtracts.cs
@@ -504,7 +504,7 @@ namespace LessMsi.Msi
 								Path originalCabFile = Path.Combine(msi.Parent, cabSourceName);
                                 if (!originalCabFile.Exists)
                                 {
-                                    throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString);
+                                    continue; //throw ExternalCabNotFoundException.CreateFromCabPath(cabSourceName, msi.Parent.FullPathString);
                                 }
 								FileSystem.Copy(originalCabFile, localCabFile);
 							}
@activescott
Copy link
Owner

Thanks @marakew! Would you be interested in submitting a pull request for this? I'm open to accepting this if we can make it optional. This is used as a shell script for many users and ignoring such failures may cause a problem for them. I could look into it and advise how to make it optional if that helps.

Or if you're looking for someone else to take it from here (😢😉) let us know and we can see if someone else with a similar need would pick it up...

@marakew
Copy link
Author

marakew commented May 29, 2022

too small changes for pull request
iam patch for self and all works
and just share my changes

@activescott
Copy link
Owner

Fair enough. Thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants