Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action depends on GNU tar #17

Open
ncfavier opened this issue Aug 19, 2022 · 2 comments
Open

This action depends on GNU tar #17

ncfavier opened this issue Aug 19, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@ncfavier
Copy link
Contributor

...because of the --hard-dereference flag, and hence will not work in environments where GNU tar is not available, like minimal containers.

Possible solutions:

  • make GitHub Pages accept artifacts containing hard links (is there a technical reason it can't?)
  • if GNU tar isn't available, fall back to not using --hard-dereference. This will still work fine in most cases where there are no hard links.
  • embrace the dependency, but document it
@yoannchaudet
Copy link
Contributor

I'll be on vacation for a few weeks but dropping a message here before it feels we are not taking a look!

The problem of tar is that there are multiple implementation and they have different options...

We don't accept any links in Pages, hard or symbolic. We also do server side validation to prevent that (it all comes down to security). Having the client (i.e. the action in the runner) use --hard-dereference allows for a seamless conversion for the rare cases someone would include hard links in what they build. Considering dropping the --hard-dereference option to use a common denominator set of tar options (which in practice is dumb, but will also expand the scope of where the action can run).

@sykhro
Copy link

sykhro commented Feb 22, 2023

+1 on documenting it.

@JamesMGreene JamesMGreene added the documentation Improvements or additions to documentation label Mar 24, 2023
Locietta referenced this issue in Locietta/blog-lost-pieces Oct 1, 2023
Locietta added a commit to Locietta/loia-dev-container that referenced this issue Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants