Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cache type bun #1034

Open
koozz opened this issue May 7, 2024 · 3 comments
Open

Add support for cache type bun #1034

koozz opened this issue May 7, 2024 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@koozz
Copy link

koozz commented May 7, 2024

Description:
The setup-node action is a popular tool for setting up Node.js environments in GitHub Actions workflows. Currently, it supports npm, pnpm, and yarn as package managers. However, there’s a need to include support for Bun, a faster JavaScript runner.

Justification:
Bun offers performance improvements over traditional JavaScript runners, making it an attractive choice for developers. By adding support for Bun in the setup-node action, GitHub Actions workflows can benefit from its speed and efficiency.

Are you willing to submit a PR?
I will have a look.

@koozz koozz added feature request New feature or request to improve the current logic needs triage labels May 7, 2024
@koozz koozz mentioned this issue May 7, 2024
2 tasks
@aparnajyothi-y
Copy link
Contributor

Hello @koozz, Thank you for creating this feature request and we will get back to you once we have some feedback on this :)

@silverwind
Copy link

I think such a cache should likely be part of https://github.com/oven-sh/setup-bun.

@koozz
Copy link
Author

koozz commented May 10, 2024

I reckon this action should cache all node dependencies, right? Since we run this after setup-node or setup-bun, whether we use npm, pnpm, yarn or bun. It felt the like the right place where this action does 1 thing and does it well (with a post step to store the cache).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants