Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation false-positives in diff editor #65

Open
OmarTawfik opened this issue Feb 4, 2024 · 0 comments
Open

validation false-positives in diff editor #65

OmarTawfik opened this issue Feb 4, 2024 · 0 comments

Comments

@OmarTawfik
Copy link

This validation is very helpful when editing workflow files:

context.error(job.ref, new Error("Unable to find reusable workflow"));

But unfortunately, it runs not only on opened VS Code editors, but on diff editors as well. And in diff editors, it triggers false positives on all relative file paths. Example:

image

I suspect this might be because diff editors have different file url scheme, so it is unable to consolidate that with file:// lookup?
Additionally, it triggers on both the before and after file editors.

I wonder if it is possible to detect diff editors, and skip running this kind of validation when not possible?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant