Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request activity type missing (de)milestoned #51

Open
1 of 4 tasks
flying-sheep opened this issue Aug 1, 2023 · 0 comments
Open
1 of 4 tasks

Pull request activity type missing (de)milestoned #51

flying-sheep opened this issue Aug 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@flying-sheep
Copy link

flying-sheep commented Aug 1, 2023

Describe the bug
Valid pull request event types include milestoned and demilestoned (like issue event types), but the schema doesn’t show them:

"pull-request-activity-type": {
"allowed-values": [
"assigned",
"unassigned",
"labeled",
"unlabeled",
"opened",
"edited",
"closed",
"reopened",
"synchronize",
"converted_to_draft",
"ready_for_review",
"locked",
"unlocked",
"review_requested",
"review_request_removed",
"auto_merge_enabled",
"auto_merge_disabled"
]
},

To Reproduce
Steps to reproduce the behavior:

  1. Try to validate your valid workflow (it runs as expected when adding or removing a milestone)
  2. see validation errors for the milestoned and demilestoned event

Expected behavior
milestoned and demilestoned are accepted as valid

Screenshots
grafik

Package/Area

  • Expressions
  • Workflow Parser
  • Language Service
  • Language Server

Package Version
v0.3.6

Additional context
The GitHub docs are also inconsistent here: The webhook docs list those event types but the workflow syntax docs don’t.

A said: It’s definitely valid. Using the event types works, part of the docs mention the event types, and clearly adding milestones to a PR is something you can do both with the API and the web UI.

@flying-sheep flying-sheep added the bug Something isn't working label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant