Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value 'github-pages' is not valid #344

Open
ioquatix opened this issue May 7, 2024 · 5 comments
Open

Value 'github-pages' is not valid #344

ioquatix opened this issue May 7, 2024 · 5 comments

Comments

@ioquatix
Copy link

ioquatix commented May 7, 2024

Not sure why this happens, but looks like the schema validation in VSCode reports this error:

image

It's a little confusing as I believe this is actually correct.

@yoannchaudet
Copy link
Collaborator

Cannot see the whole workflow in the screenshot but GitHub Pages does not really own the VS code extension anyway.

Would you mind asking in https://github.com/orgs/community/discussions/categories/actions?discussions_q=is%3Aunanswered+category%3AActions?

@ioquatix
Copy link
Author

ioquatix commented May 8, 2024

It would be this one https://github.com/socketry/async/blob/main/.github/workflows/documentation.yaml which I use across multiple projects.

I suppose there must be a schema for this file, defined by VSCode, which doesn't take into account GitHub pages...

@ioquatix
Copy link
Author

ioquatix commented May 8, 2024

I found the schema and created an issue ☝🏼

grmbyrn added a commit to grmbyrn/torrust-website that referenced this issue Jun 7, 2024
Add back in removed environment. Error being shown raised in GitHub Actions with this issue: actions/deploy-pages#344
@NicoWeio
Copy link

Just to stress: This means that the example code from this action's README yields a linting error.
I just filed a crude PR upstream (actions/languageservices#80).

@NicoWeio
Copy link

NicoWeio commented Jun 10, 2024

Whoa, looks like our efforts were totally misdirected.

Apparently, the GitHub Actions extension performs a lookup for existing environments in one's repo and complains about any non-existing ones, even though the workflow might run fine and just create one.
See github/vscode-github-actions#215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants