Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to only keep tagged versions with min-versions-to-keep #111

Open
ramblingenzyme opened this issue Sep 7, 2023 · 0 comments
Open

Comments

@ramblingenzyme
Copy link

We were trying to use this action to clean up a Docker package/repo we use exclusively for build cache. This is because our actual images to go AWS ECR, which does not have production ready build cache support. aws/containers-roadmap#876

We also chose this over using GH Actions cache, as we haven't optimised our container size and filled the Actions cache quota very quickly.

We were trying to run this action twice in a workflow to one to delete all the untagged versions and one to clear out old tagged versions.

Because we've let our build cache images pile up, not all untagged images were deleted, and the second action, which uses min-versions-to-keep removed some tagged images. This was unexpected for us, as we thought that the action would ignore untagged images when considering which images to keep.

Essentially this change to src/delete.ts is what we expected.
image

However, I understand changing this behaviour would be a breaking change, and add further complexity to this action. It could instead be part of another input, but the inputs are very complex already. #110

We've also realised that this action is better used as an ongoing cleanup, rather than trying to make it go back and clean up what's already piled up. Perhaps some mention of this in the documentation could be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant