Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): cleaned up irrelevant dependencies in ui-contract-editor #328

Closed
wants to merge 12 commits into from
Closed

chore(deps): cleaned up irrelevant dependencies in ui-contract-editor #328

wants to merge 12 commits into from

Conversation

Cronus1007
Copy link
Contributor

@Cronus1007 Cronus1007 commented Apr 5, 2021 •
edited
Loading

Closes #53

Changes

Changes
Removed rimraf package
Removed npm-run-all package
Flags
NPM documentation for rimraf https://www.npmjs.com/package/rimraf
NPM documentation for npm-run-all https://www.npmjs.com/package/npm-run-all
Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Cronus1007 and others added 12 commits March 12, 2021 16:05
@Cronus1007
Merge pull request #1 from accordproject/master
4063bde 
fix(ui-markdown-editor): text deselection - accordproject#291 (accordproject#292)
@Cronus1007
Merge pull request #3 from accordproject/master
d921339 
fix(ui-markdown-editor): handle cut image operation - accordproject#294 (accordproject#298)
@Cronus1007
Merge pull request #4 from accordproject/master
1a70996 
bump
@Cronus1007
Merge pull request #5 from accordproject/master
2e189ca 
nkkk
@Cronus1007
Merge pull request #8 from accordproject/master
43e10c7 
bump
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
250845c 
Signed-off-by: Cronus1007 <[email protected]>
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
505ceed 
Signed-off-by: Cronus1007 <[email protected]>
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
2df417e 
Signed-off-by: Cronus1007 <[email protected]>
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
099caf6 
Signed-off-by: Cronus1007 <[email protected]>
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
ff797d9 
Signed-off-by: Cronus1007 <[email protected]>
@Cronus1007
Merge branch 'issue-53' of https://github.com/Cronus1007/web-components…
b554a2f 
… into issue-53
@Cronus1007
chore(deps): cleaned up irrelevant dependencies in ui-contract-editor
af60145 
Signed-off-by: Cronus1007 <[email protected]>
@irmerk
Copy link
Member

irmerk commented Apr 6, 2021

Unsure why there are additions to packages/ui-contract-editor/package-lock.json when we've removed dependencies. Can you rebase to consolidate down to one commit so this may be easier?

@Cronus1007
Copy link
Contributor Author

@irmerk I will start with a fresh pr.

@Cronus1007 Cronus1007 closed this Apr 6, 2021
@Cronus1007 Cronus1007 deleted the issue-53 branch April 6, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies Cleanup
2 participants
@Cronus1007 @irmerk