Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies Cleanup #53

Open
irmerk opened this issue Apr 30, 2020 · 6 comments
Open

Dependencies Cleanup #53

irmerk opened this issue Apr 30, 2020 · 6 comments
Assignees
@Cronus1007
Labels
Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file
Projects
Cicero UI v1.0 Web Components v1.0

Comments

@irmerk
Copy link
Member

irmerk commented Apr 30, 2020

Need to take a hard look at all our dependencies. This library is pretty big.

This impacts security, development workflow (slow builds), and page load times.
@irmerk irmerk pinned this issue May 4, 2020
@irmerk irmerk transferred this issue from accordproject/cicero-ui May 13, 2020
@irmerk irmerk added Help Wanted 🆘 Extra attention is needed Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file Type: Enhancement ✨ Improvement to process or efficiency Type: Need Investigation 🔬 labels May 13, 2020
@irmerk irmerk added this to Triage in Web Components v1.0 via automation May 18, 2020
@irmerk irmerk moved this from Triage to Priority: High in Web Components v1.0 May 18, 2020
@aashrafh
Copy link

I want to work on it. I understood that it needs someone to investigate the code and make sure that all of these dependencies are used and suggest a better/lighter alternative, right?

@irmerk
Copy link
Member Author

irmerk commented Dec 28, 2020

That's correct @aashrafh, and some of the dependencies may be unused.

@aashrafh aashrafh removed their assignment Jan 15, 2021
@Cronus1007
Copy link
Contributor

Cronus1007 commented Mar 11, 2021 •
edited
Loading

@irmerk Shall I start work upon this issue.This package has the dependencies as stale like npm-run-all and rimraf.

@irmerk
Copy link
Member Author

irmerk commented Mar 11, 2021

Could you please outline what you plan to change here before opening a PR?

@Cronus1007
Copy link
Contributor

@irmerk I have laid out the same plan for this package as well. Check this out #52 (comment)

@irmerk
Copy link
Member Author

irmerk commented Apr 2, 2021

Sorry for the delay, I think this makes sense @Cronus1007

@irmerk irmerk removed Help Wanted 🆘 Extra attention is needed Type: Enhancement ✨ Improvement to process or efficiency Type: Need Investigation 🔬 labels Apr 2, 2021
@Cronus1007 Cronus1007 mentioned this issue Apr 5, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cronus1007 Cronus1007

Labels
Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file
Projects
Web Components v1.0
  
Priority: High
Cicero UI v1.0
  
Priority: High
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): cleaned up irrelevant dependencies in ui-contract-editor Cronus1007/web-components
3 participants
@irmerk @aashrafh @Cronus1007