Possible to split paragraphs in half with drag and drop

[Michael-Grover]

Bug Report 🐛

Dragging and dropping a Clause Template into the margins to the left or right of a paragraph allows the Clause Template to split the paragraph in half.

Expected Behavior

The Clause Template should be placed before or after the paragraph

Current Behavior

https://www.loom.com/share/329b20b14ecf4cd9854d31dba93b5e92

Possible Solution

Steps to Reproduce

1. drag Clause Template
2. drop into margin in the middle of paragraph
3. paragraph is split in half

[irmerk]

This can be undone and also fixed manually, so not super serious.

@DianaLease playing with the CSS in the demo, I think this is because the drop point is in the padding of ap-rich-text-editor. Could we maybe just switch to margin instead?

[gatij10]

@Michael-Grover is this issue still open? I would like to work on it.

[irmerk]

@gatij10 test it out in the live Storybook and see if the issue still exists.

[gatij10]

@irmerk I tested it out in the live storybook, looks like the issue still exists. I will try to solve it.

[Cronus1007]

@Michael-Grover @irmerk Since the issue exists in the live storybook so shall I work upon this issue.

[Cronus1007]

@DianaLease playing with the CSS in the demo, I think this is because the drop point is in the padding of ap-rich-text-editor. Could we maybe just switch to margin instead?

@irmerk This one is not working.The problem may arise bcoz there is not any type of function which handles drop. So what I intend to do is write the handleDrop function to handle the Drop. Does it sound good to proceed?

[irmerk]

I think @DianaLease is more familiar with this code and can be of more help at the moment. I won't have a chance to look into this for a bit.

[DianaLease]

hi @Cronus1007 . The logic that handles drop for the contract editor is here:

web-components/packages/ui-contract-editor/src/ContractEditor/index.js

Line 199 in 5c92ecb

const onDrop = (editor, event) => {

This function is passed to the MarkdownEditor as a prop where it gets called whenever a drop event fired.

[Michael-Grover]

I'm cleaning up old issues I created, and it looks like this one hasn't been resolved, so I'm keeping it open in case a hacktoberfest 2021 participant wants to give it a shot

[vikasazad]

Hi @irmerk I wanted to work on this..?

[TC5022]

Hello @irmerk , may I work on this issue, if it's still open?

[vikasazad]

Hi @irmerk @DianaLease where i can ask doubts regarding the problem cause slack link is offline...?

[Michael-Grover]

Hi @vikasazad , the Accord Project now uses Discord instead of Slack, you can join at this link: https://discord.gg/xPPT3gVt

If you have questions about this issue, you can add them as a reply to this github issue

[irmerk]

I'll assign this to someone when there is a work in progress PR on it.

[anmode]

Hey! This is issue still exist in the storybook live demo and I had checked the code base of contract editor. I am unable to identify the what causing this issue, need some guidance please